Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Remove dept-devops from CODEOWNERS #9564

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-101

📔 Objective

Remove dept-devops from CODEOWNERS and add dept-bre for all release workflows.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski added the hold do not merge, do not approve yet label Jun 10, 2024
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jun 10, 2024
@michalchecinski
Copy link
Contributor Author

Wait for the https://bitwarden.atlassian.net/servicedesk/customer/portal/5/TSD-648 to be done.

@michalchecinski michalchecinski requested a review from a team June 10, 2024 14:09
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.30%. Comparing base (c8eac6f) to head (9cf4f55).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9564      +/-   ##
==========================================
+ Coverage   28.16%   28.30%   +0.14%     
==========================================
  Files        2432     2437       +5     
  Lines       71590    71654      +64     
  Branches    13378    13398      +20     
==========================================
+ Hits        20161    20285     +124     
+ Misses      49838    49775      -63     
- Partials     1591     1594       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Logo
Checkmarx One – Scan Summary & Details5a78af45-4133-4156-9313-52156fada131

No New Or Fixed Issues Found

urbinaalex17
urbinaalex17 previously approved these changes Jun 18, 2024
@urbinaalex17
Copy link
Contributor

Wait for the https://bitwarden.atlassian.net/servicedesk/customer/portal/5/TSD-648 to be done.

Are we good to go? 🚀

@michalchecinski michalchecinski removed the hold do not merge, do not approve yet label Oct 15, 2024
@michalchecinski michalchecinski merged commit 80e6b1a into main Oct 17, 2024
14 of 18 checks passed
@michalchecinski michalchecinski deleted the BRE-101-Remove-dept-devops-from-CODEOWNERS branch October 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants