Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13829] Allow deletion for items with no collectionId(s) #11825

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Nov 1, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13829

๐Ÿ“” Objective

This PR fixes an issue where owners cannot delete unassigned items from the item modal. This change brings the logic in line with the vault component, where the item can be deleted when it is unassigned (i.e the inline delete button on the item).

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner November 1, 2024 16:13
@BTreston BTreston requested a review from gbubemismith November 1, 2024 16:13
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (a049b55) to head (379018e).
Report is 57 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...angular/src/vault/components/add-edit.component.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11825   +/-   ##
=======================================
  Coverage   33.53%   33.53%           
=======================================
  Files        2814     2814           
  Lines       87465    87470    +5     
  Branches    16676    16678    +2     
=======================================
+ Hits        29330    29333    +3     
- Misses      55830    55831    +1     
- Partials     2305     2306    +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@BTreston BTreston merged commit 2c5221d into main Nov 6, 2024
66 of 67 checks passed
@BTreston BTreston deleted the ac/pm-13829-delete-unassigned-items-from-item-modal branch November 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants