[PM-13818] Allow user to edit self-hosted url during registration #11790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11790 +/- ##
==========================================
- Coverage 33.63% 33.62% -0.01%
==========================================
Files 2821 2823 +2
Lines 88115 88171 +56
Branches 16784 16797 +13
==========================================
+ Hits 29635 29647 +12
- Misses 56160 56202 +42
- Partials 2320 2322 +2 ☔ View full report in Codecov by Sentry. |
…-url-during-registration
willmartian
requested changes
Oct 30, 2024
Comment on lines
115
to
121
| private handleSelfHostedSelection(prevSelectedRegion: RegionConfig | Region.SelfHosted | null) { | ||
| return from(SelfHostedEnvConfigDialogComponent.open(this.dialogService)).pipe( | ||
| tap((result: boolean | undefined) => | ||
| this.handleSelfHostedEnvConfigDialogResult(result, prevSelectedRegion), | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Converting the open promise to an observable requires a lot of ceremony that isn't buying us anything, since we are effectively converting it back to a promise with take(1) and subscribe() in onSelectClosed.
What do you think of this alternative?
type RegionSelection = RegionConfig | Region.SelfHosted | null;
protected async onSelectClosed(selection: RegionSelection) {
if (selection === Region.SelfHosted) {
const result = await SelfHostedEnvConfigDialogComponent.open(this.dialogService)
return this.handleSelfHostedEnvConfigDialogResult(result, selection);
}
}…-url-during-registration
…-url-during-registration
willmartian
requested changes
Nov 5, 2024
…-registration' of https://github.com/bitwarden/clients into auth/pm-13818/allow-user-to-edit-self-hosted-url-during-registration
…-url-during-registration
…-url-during-registration
willmartian
requested changes
Nov 6, 2024
| @@ -31,6 +33,7 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce | |||
| /** Optional: Options can be provided using an array input or using `bit-option` */ | |||
| @Input() items: Option<T>[] = []; | |||
| @Input() placeholder = this.i18nService.t("selectPlaceholder"); | |||
| @Output() closed = new EventEmitter<T>(); | |||
There was a problem hiding this comment.
Suggested change
| @Output() closed = new EventEmitter<T>(); | |
| @Output() closed = new EventEmitter(); |
Comment on lines
181
to
186
| protected async onSelectClosed(selection: RegionSelection) { | ||
| if (this.selectedRegion.value === Region.SelfHosted) { | ||
| const result = await SelfHostedEnvConfigDialogComponent.open(this.dialogService); | ||
| return this.handleSelfHostedEnvConfigDialogResult(result, selection); | ||
| } | ||
| } |
There was a problem hiding this comment.
This needs to be refactored to no longer expect a parameter, correct? Since close no longer emits a value.
There was a problem hiding this comment.
Whoops yes - here's the fix: 2533716
|
New Issues
Fixed Issues
|
willmartian
approved these changes
Nov 6, 2024
JaredSnider-Bitwarden
approved these changes
Nov 6, 2024
alec-livefront
deleted the
auth/pm-13818/allow-user-to-edit-self-hosted-url-during-registration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13818?atlOrigin=eyJpIjoiZmQ2Njc1OTg0NTg5NGI1NDkxMjdhZmQ0NThiOGJmZjciLCJwIjoiaiJ9
📔 Objective
Re-launch the
self-hosted-env-config-dialogafter a user has previously selected the self hosted option from the "Creating account on" select. This allows a user to go back and edit values after the dialog has closed.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes