-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13818] Allow user to edit self-hosted url during registration #11790
Merged
alec-livefront
merged 14 commits into
main
from
auth/pm-13818/allow-user-to-edit-self-hosted-url-during-registration
Nov 6, 2024
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fcf50f4
Trigger self hosted settings dialog on select close
alec-livefront 7cdf48f
Merge branch 'main' into auth/pm-13818/allow-user-to-edit-self-hostedโฆ
alec-livefront 6d92fcb
Simplify triggering self hosted env config dialog
alec-livefront 13704a9
Always emit selected value
alec-livefront d0024bf
Update variable naming of lastSelectedValue to userSelectedValue to bโฆ
alec-livefront 1197e15
Merge branch 'main' into auth/pm-13818/allow-user-to-edit-self-hostedโฆ
alec-livefront a95dea2
Add comment for userSelectedValue variable
alec-livefront 6270014
Merge branch 'main' into auth/pm-13818/allow-user-to-edit-self-hostedโฆ
alec-livefront 8aa2b7b
Merge branch 'main' into auth/pm-13818/allow-user-to-edit-self-hostedโฆ
alec-livefront 38ceaf6
Merge branch 'auth/pm-13818/allow-user-to-edit-self-hosted-url-duringโฆ
alec-livefront 820210e
Remove userSelectedValue and simply emit a closed event
alec-livefront ae3055d
Merge branch 'main' into auth/pm-13818/allow-user-to-edit-self-hostedโฆ
alec-livefront f1c6d6f
Merge branch 'main' into auth/pm-13818/allow-user-to-edit-self-hostedโฆ
alec-livefront 2533716
Remove passing selectedRegion in closed event
alec-livefront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...c/angular/registration/registration-env-selector/registration-env-selector.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.