-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11505]Delete the feature flag PM-5864-dollar-threshold #11436
Merged
cyprain-okeke
merged 5 commits into
main
from
pm-11505-delete-the-feature-flag-pm-5864-dollar-threshold
Nov 6, 2024
Merged
[PM-11505]Delete the feature flag PM-5864-dollar-threshold #11436
cyprain-okeke
merged 5 commits into
main
from
pm-11505-delete-the-feature-flag-pm-5864-dollar-threshold
Nov 6, 2024
+2
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11436 +/- ##
==========================================
+ Coverage 33.62% 33.63% +0.01%
==========================================
Files 2821 2821
Lines 88126 88115 -11
Branches 16787 16784 -3
==========================================
+ Hits 29629 29635 +6
+ Misses 56177 56160 -17
Partials 2320 2320 ☔ View full report in Codecov by Sentry. |
cturnbull-bitwarden
previously approved these changes
Oct 7, 2024
cturnbull-bitwarden
approved these changes
Nov 6, 2024
cyprain-okeke
deleted the
pm-11505-delete-the-feature-flag-pm-5864-dollar-threshold
branch
November 6, 2024 15:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11505
📔 Objective
Delete the feature flag PM-5864-dollar-threshold
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes