[New arch] Synchronization #2818
Assignees
Labels
Comments
This was referenced Apr 24, 2020
This was referenced Apr 30, 2020
This was referenced Aug 12, 2020
Create Folder #2861 [APPROVED]AC:
QA:
Reports and improvements: (1) Create folder with an existing name [FIXED]Current: Nexus6P Android7 |
Fetch List of files #2873
|
This was referenced Oct 26, 2020
Closed
Remove file or folder #2864AC:
QA:
Reports and improvements (1) [FIXED]
Current: Only option to remove remotely. Nexus 6P Android 7 (2) [FIXED]
Current: Remove operation fails because lack of connection Pixel5 v12 (3) [P2]
Current: Spinner and waiter in the screen for a long time. App is blocked for the user. Samsung A51 Android12 (4) [P2]
Current: List of files is cleaned up and file name is set on the tool bar Samsung A51 Android 12 |
Download a single file #2872AC: https://github.com/owncloud/QA/blob/master/Mobile/Android/Sync/Download%20.md Not finished yet. Following points are needed before approval:
Issues: (1) (p1)
Current: app crashes Pixel 5 Android12 |
This was referenced May 19, 2021
Closed
Move #2865 [APPROVED]AC: https://github.com/owncloud/QA/blob/master/Mobile/Android/Sync/Move.md Pending:
Reports and improvements: (1) Crash [FIXED]
Current: app crashes. Stacktrace: Nexus6P Android7 |
Rename #2863 [APPROVED]AC: https://github.com/owncloud/QA/blob/master/Mobile/Android/Sync/Rename.md Reports and improvements (1) Rename with > 250 chars [FIXED]Rename an item, adding a name longer than 250 Current: Nexus6P Android7 (2) Rename with empty [FIXED]Rename an item, letting the input text field empty Current: Nothing happens (3) Rename with "/" [FIXED]Rename an item, including forbidden "/" character Current: Nothing happens (4) Rename with existing name of folder [FIXED]Rename a folder, using an existing name in the same directory Current: Nexus6P Android7 |
Copy #2866AC: https://github.com/owncloud/QA/blob/master/Mobile/Android/Sync/Copy.md Files downloaded won't be copied in the local storage. We may save some local space this way, but we could duplicate them if needed. Reports and improvements: (1) [FIXED]Same crash as report (1) in (2) [FIXED]
Current: in the bottom folder picker button: (3)
Current: error message is too long, and could not be read completely:
Expected ( NOTE: same for move |
File list viewThe main screen of the app has been refactored. Lots of changes have been applied including recycler view, live data... etc Reports and improvements (1) Multiselection [FIXED]When long pressing, the multiselection checkboxes only displayed for the selected item:
(2) Share icons [FIXED]
Current: Sharing icons are gone (3) Thumbnails non-downladed files [FIXED]Thumbnails for non-downloded files are lost. Related: #3525 (4) [DONE]
(5) [DONE]The new message when the folder is empty:
I'd remove the (6) [FIXED]Scroll bar on the right is missing (comparing with |
DownloadsQA https://github.com/owncloud/QA/blob/master/Mobile/Android/Sync/Download%20.md Known issues: downloading badge is not shown Reports and improvements: (1) Crashes [No reproducible]Some kind of files cause a crash when clicking on them to download and preview: pdf, video, txt (2) Notifications [FIXED]Current: Expected (master): using the down-arrow to download, should show also de notification (i know that notifications are pending to be rechecked) Obs: Currently, the progress in the notification is not shown. It only shows the notification when the download is finished (success or fail). That said, I got the notification when using the down-arrow to download, so it could be fixed by the way. Ready to check again @jesmrec (3) In uploads view [FIXED]
Current: some seconds later, the file appears in the uploads view (does it try to sync?) (4) [FIXED]Something not to forget in our side: we have to mark somehow when a file is downloaded. Using the green badge as before or any other way. (5) [P1] [FIXED]
Current: Obs: (Only reproducible with images(?), otherwise in the details view, we will see a snackbar("Sync failed")). (6) [P2]This one is about notifications, so maybe not to fix as downloads but directly related
Current: notification (7) [P2]
Current: Progress bar is missing Nexus6P Android7 |
|
@jesmrec Atomic operations are ready to test again |
Open With(1) Crash [FIXED]
Current: app crashes Expected: no crash Android 7 |
Uploads(1) (p2) [FIXED]
Current: error takes long to happen (no notification) (2) [FIXED]
Current: UPDATE: (3) (p3)
Current: (4) (p1) [FIXED in https://github.com//pull/3757]
Current: NOTE: URI upload (manual upload via FAB) returns folder error. System upload (share with oC) sometimes resumes after reopening correctly, other times fails with unknown error in uploads view and (5) (p2)When a file is uploaded, the notification is missing. Is this intended or pending to do? Note: same behaviours as downloads is feasible (6) [FIXED]
Current: nothing is uploaded Android 7, Android12 (7) [Non-reproducible]
Current: sometimes app crashes, and sometimes it doesn't crash but not every file was uploaded Logs:
Click meSamsung Galaxy S9, Android 9 UPDATE: Samsung Galaxy S9, Android 9 (8) (p1) [FIXED via https://github.com//pull/3763]
Current:
it seems that the PUT takes longer that a timeout somewhere, so it fails. Are chunks missing? NOTE: URI uploads with a single PUT. System uploads are chunked. In the
(9) [FIXED]
Current: uploads removed in step 3 are finally uploaded.
UPDATE: Samsung Galaxy S9, Android 9 UPDATE (24/08/2022) Problem is still reproducible on my side. In order to clarify, i recorded a video: device-2022-08-24-105357.mp4.zip 20 pictures are selected. In the uploads view, the pictures' name ending in I reproduced that with Samsung A51 and Nexus 6P (10) [FIXED]
Current: uploads view shows the failed uploads as
(11) [Won't fix, same as (4)]
Current: Upload failed with
UPDATE: (12) [FIXED]
Current: File not uploaded, no entry in uploads view
(13) [FIXED]Not sure if this report is specific of uploads or will fit better in another section (database?). Feel free to comment, and report will be moved to another place
Current: crash
(14) (p2)Open to discussion: when a bunch of files is uploaded and uploads run fast. it's difficult to check what's going on in the uploads view because items move up and down very fast in a non-readable way: device-2022-08-18-145000.mp4
(15) (p1) [FIXED in https://github.com//pull/3757]Select a huge amount of files to upload manually. Part of them are uploaded but finally, most are move to failed with device-2022-08-24-134158.mp4.zip This log corresponds with the screen recording: I also reproduced this with another device. In the Logcat, i see this log as well: NOTE: URI uploads (manual FAB) reproduce the problem. With system uploads (sharing with oC), problem is not reproducible.
(16) [FIXED]
Current: uploads removed in step 3 are finally uploaded. Samsung Galaxy S9, Android 9 (17) (p1) (check comments in (4). Related) [FIXED in https://github.com//pull/3757]
Current: Upload failed with Samsung Galaxy S9, Android 9 (18) (p3)
Current: Pending files with the status
Expected: different status. File uploading with Samsung A51 (19) (p3) (improvement)
Current: it may happen that the amount of enqueued files is very big. For example:
Do you think it'd be interesting to add a Samsung Galaxy S9, Android 9 |
File synchronizationIssue: #3350 (1) [P2]
Current: Sync badge is gone Samsung A51 (2) [P2]
Samsung A51 Current: download enqueued but old content displayed Known restrictions: #3350 (comment)
|
Folder SynchronizationIssues: (1) (p2) [@jesmrec Same as 2.21.1 I would say. Relocation mechanism pending to implement]
Current: file list updates the file with the new name. But, internally (Scoped Storage), file is not renamed. (i guess it should) Pixel5 Android12 (2) [FIXED]Not sure if something to do with the current stuff, but in the branch (commit (3) [FIXED]
Current: new item in parent is not listed after browsing back. Pull to refresh will update it Pixel5 Android12 (4) [FIXED]
Current: file is removed from app Pixel5 Android12 NOTE: same effect by executing steps with folders, and also when files are downloaded. (5) (p3) [IMPROVEMENT] [DONE]
Current: nothing happens NOTE: same without server connection or maintenance mode (6) (p1) [FIXED]
Current: after showing the list of files, the whole account is refreshed recursively. Is this intended? Expected: previous behaviour was syncing only the current folder. Sync the whole account is not a bad behaviour but, in case the number of items is huge, the number of requests rise a lot. Maybe using the the infinite propfind is a better solution (ios related issue). Also, the progression bar on the top blinks till everything is done (in case of ~6K, many minutes) Pixel 5 v12 (7) (p1) [FIXED]Following (6)
Current: all files in the app are synced Pixel 5 v12 (8) (p1) [FIXED]
Current: for every item inside the folder, three requests are done (two propfind and one get). Is this expected? In previous version, only one request was done by item in the synced folder. Pixel 5 v12 |
Available offlineIssues: (1) [FIXED]
Current: screen-20220729-091442.mp4Expected: Image previewed NOTE: That happens also with videos Pixel 5 Android12 (2) (check with file sync) (P2)Reminder: as commented here, if new version in server, opening the file does not show it. (3) [FIXED]
Current: content not visible NOTE: if the folder was previously discovered, content is not synced either. 2022-08-31 NOTE: content is discovered but not synced. A manual refresh forces the sync, but it must be automatic Pixel 5 Android12 (4) (p1)
Current: app crashes: Expected: no crash NOTE: same behaviour by moving a subfolder from av. offline folder. Pixel 5 Android12 (5) [FIXED]
Current: av. offline file was not synced, not including the modifications added in 3. After re-opening the app, file is synced. UPDATE 2022-09-01: Problem is still reproducible with commit Pixel 5 Android12 (6) (improvement) (p3)
Current: The option
Pixel 5 Android12 (7) Will be fixed within #3730 (p1) [FIXED]maybe related with: #3721
Current: Items are still av. offline Pixel 5 Android12 |
This was referenced Aug 11, 2022
Bottom Navigation BarReferenced: #3719 Issues: (1) [FIXED]
Current: crash NOTE: same when selecting av. offline Samsung A51 Android12 (2) [FIXED]Comparing with the current
Samsung A51 Android12 (3) [FIXED]Small glitch:
Current: Selection mode is enabled, but checkboxes are gone and number of items is incorrect in the toolbar: device-2022-08-17-095449.mp4Expected: selection mode disabled. selection mode enabled bit with checkboxes and correct values NOTE: similar behaviour in av. offline tab Samsung A51 Android12 (4) [FIXED]
Current: crash Samsung A51 Android12 (5) (p3)Related to #3498
Current: Toolbar shows
(6) To fix in #3016Already reported #3016
Current: item is still in the list, even though the link was removed and the item is not shared by link anymore. Item is removed from the links list when the containing folder is browsed. Expected: link removed, item not listed
|
Notificationsstatus 2022-08-19
|
Uploads migration(1) [FIXED]
Current: uploads stay in "Enqueued" and never resume
(2) (p1) [FIXED]
Current: app crashes. This is the stacktrace: Expected: no crash and upload resumed Samsung A51 Android 12 (3) (p1) [WON'T FIX]
Current: Uploads view empty. After some seconds, 50 files uploading again Video with last 2 steps device-2022-09-06-144004.mp4Samsung A51 Update 23/09/22: (4) (p2)
Current: upload stucked and never ends. Samsung A51 |
Miscellaneous(1) [P2]
Current: toolbar is not correct. It includes items of root folder instead of Details view Samsung A51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Introduction
We have been working on updating the old Android App to a new architecture for a long time.
The new architecture is MVVM and we can find more details about it here: #2351
To do this, we started with Shares functionality, we continued with Authentication, and finally, we are working on the most crytical part of the app: the Synchronization. This last epic is huge and we created a milestone to keep track of it: https://github.com/owncloud/android/milestone/43
Synchronization
App PR: #2934
Library PR: owncloud/android-library#339
Atomic Operations
Create folder [QA Passed] ✅
Issue: #2861
PR: #2923
QA: #2818 (comment)
QA reports fixed:
Rename [QA Passed] ✅
Issue: #2863
PR: #3231
QA: #2818 (comment)
QA reports fixed:
Remove [Bugfixing]
Issue: #2864
PR: #3214
QA: #2818 (comment)
QA reports fixed:
Copy [Bugfixing]
Issue: #2866
PR: #3253
QA: #2818 (comment)
QA reports fixed:
Move [QA Passed] ✅
Issue: #2865
PR: #3232
QA: #2818 (comment)
QA reports fixed:
Transfers
Transfers have changed completely from the previous version. We have moved from foreground services to WorkManager. They can be done parallely now.
Some notifications have been removed, previously it was a little bit messy when several uploads/downloads were done very fast.
Uploads [Bugfixing]
There are two types of uploads at the moment.
Plain Uploads: When we get the content Uri via SAF or Camera Uploads
Plain or Chunks(depending on file size): When we share with oC, via documents provider, upload via camera, and when we upload conflicts.
Issue: #3424
PR: #3686
QA: #2818 (comment)
QA reports fixed:
Downloads [Bugfixing]
Issue: #2872
PR: #2918
QA: #2818 (comment)
QA reports fixed:
Open with [Bugfixing]
QA: #2818 (comment)
QA reports fixed:
Store uploads into the new Room database [Bugfixing]
At the moment, we have the uploads database in the old database. We need to move it to the new one. Also, we need to move the current OCUpload model to the domain module. By the way, we should consider adding Downloads to that new table. At the moment we don't store the downloads in the database and it could be beneficial.
Issue: #3426 & #3717
PR: #3710 & #3729
Transfers view [Bugfixing]
We need to adapt the uploads screen when we migrate the database. The idea is to take advantage of room improvements and observe any change via LiveData or Flow. By the way, we think that it would be a good idea to transform the uploads screen into a Transfer screen where the user could check the latest transfers, not only the uploads but also the downloads.
Issue: #2858
PR: #3718
File list view [Bugfixing]
The main screen of the app has been refactored. Lots of changes have been applied including recycler view, live data... etc
Issue: #2869
PR: #3517
QA: #2818 (comment)
QA reports fixed:
Av. Offline [Bugfixing]
As we already did some time ago with the camera uploads periodic work, we need to move the av offline job to work manager.
Issue: #3246
PR: #3715
QA: #2818 (comment)
QA reports fixed:
Bottom navigation bar [Bugfixing]
At the moment the bottom navigation bar is not working properly. It should update the file list with the new upload list option and show only the files for that shortcut.
PR: #3719
QA: #2818 (comment)
QA reports fixed:
Conflicts Management [TO DO]
We need to detect if there are new conflicts between local and remote files and let the user choose to keep local, remote or both.
Issue: #3005
Refresh folder [Tested with folder synchronization]
Refreshing the folder should keep the folder updated with remote content and also, remove any file locally that is not available on the remote server anymore
Issue: #3268
PR: #3709
File synchronization [Bugfixing]
Files should be synchronized, updating or removing local data in ScopedStorage and database depending on the remote changes.
Issue: #3350
PR: #3704
QA: #2818 (comment)
QA reports fixed:
Folder synchronization [Bugfixing]
Same as file synchronization but for folders. Recursively.
PR: #3707 & #3709
QA: #2818 (comment)
QA reports fixed:
Uploads migration (Under QA)
Issue: #2858
PR: #3718
QA: #2818 (comment)
QA reports:
Miscellaneous
#2818 (comment)
Issues to have a look after this:
#3721 [FIXED]
#3741 [P1] [FIXED]
#2070
#2149
#2834
#2829
#2921 [P1] [FIXED]
#3708 [P2] [FIXED]
The text was updated successfully, but these errors were encountered: