Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Arch] UploadListFragment isolation #2858

Closed
18 tasks done
abelgardep opened this issue Apr 21, 2020 · 0 comments · Fixed by #3718
Closed
18 tasks done

[New Arch] UploadListFragment isolation #2858

abelgardep opened this issue Apr 21, 2020 · 0 comments · Fixed by #3718

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Apr 21, 2020

From a development point of view, it would be great to show a UploadListFragment within any activity. For example, with the current bottom navigation bar we need to create a new activity just to show the fragment. It would be great to simply replace one fragment with another.

At the moment, there are so many dependencies to open UploadListFragment:

  • UploadListFragment extends ExpandableListFragment which extends ExtendedListFragment.

  • UploadListFragment is created inside UploadListActivity which extends FileActivity which extends DrawerActivity

TASKS

  • Research (if needed)
  • Create branch new_arch/uploads_screen
  • Development tasks
    • Create a new fragment in kotlin with a recycler view
    • Create a new adapter for the recycler view
    • Use the ViewModel to retrieve the needed data from the usecases (all stored uploads) and store them in a livedata so the fragment can observe the changes
    • Observe the livedata and update the adapter with the transfers
    • At this point we should see something in the UI
    • Update the domain and data layers to retrieve the stored uploads as live data so we can observe them in real time
    • Create a new viewtype with its viewholder to show the headers (for example: In Progress, n items in progress, Cancel all)
    • Modify the adapter to show the uploads by TransferStatus
    • Show options Retry, Clear, Cancel depending on the transfer status group
    • Implement all the calls to retry, cancel, etc..
    • For the transfers in progress, retrieve the progress from Work manager and show a progress bar with its percentage
    • (N2H) Add a DiffUtil
    • (N2H) Generate thumbnails with Glide
  • Code review and apply changes requested
  • Merge branch new_arch/uploads_screen into new_arch/synchronization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants