-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Arch] UploadListFragment isolation #3718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
…retrieving all transfers
JuancaG05
force-pushed
the
new_arch/uploads_screen
branch
from
July 21, 2022 07:28
ba97279
to
e6942c7
Compare
75 tasks
JuancaG05
force-pushed
the
new_arch/uploads_screen
branch
from
August 11, 2022 11:54
d202546
to
d0791b8
Compare
abelgardep
suggested changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! Some suggestions and ready to merge!
owncloudApp/src/main/java/com/owncloud/android/extensions/OCTransferExt.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/extensions/TransferStatusExt.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/extensions/WorkManagerExt.kt
Outdated
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/adapters/transfers/TransfersAdapter.kt
Outdated
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/adapters/transfers/TransfersAdapter.kt
Outdated
Show resolved
Hide resolved
...udApp/src/main/java/com/owncloud/android/presentation/adapters/transfers/TransfersAdapter.kt
Outdated
Show resolved
Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/transfers/TransferRepository.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/owncloud/android/usecases/transfers/uploads/UploadFilesFromSystemUseCase.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/adapter/ExpandableUploadListAdapter.java
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/providers/WorkManagerProvider.kt
Outdated
Show resolved
Hide resolved
@abelgardep Ready for re-review and some comments! |
abelgardep
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #2858
QA