Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New arch] Migrate pending uploads to new database #3717

Closed
9 tasks done
abelgardep opened this issue Jul 18, 2022 · 0 comments · Fixed by #3729
Closed
9 tasks done

[New arch] Migrate pending uploads to new database #3717

abelgardep opened this issue Jul 18, 2022 · 0 comments · Fixed by #3729

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Jul 18, 2022

Since #3426 uploads are stored in the new database.
Since #2858 uploads view uses the new database to retrieve the queued, in progress, succeeded, and failed uploads.

This one should be the last issue for the uploads. We need to migrate the pending uploads to the new database, and then enqueue them, so they can be uploaded with the workers. I think that Camera Uploads don't need to be enqueued again, The workers should be enqueued yet, but needs some research.

Also, we need to check that the migration to scoped storage enqueues the pending uploads.

TASKS

  • Research (if needed)
  • Create branch new_arch/migrate_pending_uploads
  • Development tasks
    • Implement a new function to generate an entity from a cursor
    • Next to the migration of the files to the new database, migrate also the uploads
    • Check every use of UploadsStorageManager and refactor it to eventually remove it
    • Remove UploadBehavior.fromLegacyLocalBehavior() from RetryUploadFrom***UseCases
  • Code review and apply changes requested
  • Merge branch new_arch/migrate_pending_uploads into new_arch/synchronization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants