[New arch] Fix bottom navigation shortcuts #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 tasks
abelgardep
force-pushed
the
new_arch/bottom_nav_improvements
branch
from
67c77fa to
a6fc63b
Compare
JuancaG05
requested changes
Aug 12, 2022
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/files/SortOptionsView.kt
Outdated
Show resolved
Hide resolved
...p/src/main/java/com/owncloud/android/presentation/ui/files/filelist/MainFileListViewModel.kt
Outdated
Show resolved
Hide resolved
...a/com/owncloud/android/domain/files/usecases/GetSharedByLinkForAccountAsStreamUseCaseTest.kt
Outdated
Show resolved
Hide resolved
JuancaG05
approved these changes
Aug 16, 2022
…account, folder, filelistoption and searchfilter
…it is not available in the server
abelgardep
force-pushed
the
new_arch/bottom_nav_improvements
branch
from
018ba1f to
36f8855
Compare
abelgardep
force-pushed
the
new_arch/bottom_nav_improvements
branch
from
071ada7 to
3dd8979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace LiveData with Flow/StateFlow and retrieve directly the filtered data from the database.
The final state for the screen is generated by combining 4 other states: FileListOption, AccountName, FolderDisplayed, SortTypeAndOrder, and SearchFilter. This way, the bottom navigation shortcuts should be fixed and more could be added in the future.
Adding StateFlow also removes some nullability checks we had when retrieving the value from the LiveData.
It should fix also this issue #3666 [FIXED]
Includes support for hidden files (It was pending): #2818 (comment) [DONE]
Potential fix to thumbnails generation [FIXED]
Known issues
Grid/List configuration from the previous version will be reset
Glitch: Search, navigate to a folder and browse back shows all the content again but in the search view, it will still appear the previous query.
QA