-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New arch] Av. Offline #3715
Merged
Merged
[New arch] Av. Offline #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
…e status in dao recursively when setting a file as av offline
…us depending on the parent
…c. Just a refresh should be enough for the moment
abelgardep
force-pushed
the
new_arch/av_offline
branch
2 times, most recently
from
July 18, 2022 12:37
083cc53
to
901eece
Compare
abelgardep
force-pushed
the
new_arch/av_offline
branch
from
July 18, 2022 12:42
901eece
to
68494d5
Compare
abelgardep
force-pushed
the
new_arch/av_offline
branch
from
July 20, 2022 06:58
e9d3507
to
686a267
Compare
JuancaG05
requested changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @abelgardep! 💯
Some comments over here!
...a/src/main/java/com/owncloud/android/data/availableoffline/AvailableOfflineRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/UseCaseModule.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/files/FileMenuFilter.java
Show resolved
Hide resolved
...a/src/main/java/com/owncloud/android/data/availableoffline/AvailableOfflineRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/files/datasources/LocalFileDataSource.kt
Show resolved
Hide resolved
...ain/java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt
Show resolved
Hide resolved
...ain/src/main/java/com/owncloud/android/domain/availableoffline/AvailableOfflineRepository.kt
Outdated
Show resolved
Hide resolved
.../android/domain/availableoffline/usecases/GetFilesAvailableOfflineFromEveryAccountUseCase.kt
Show resolved
Hide resolved
JuancaG05
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #3246
QA