Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Arch] Rename file/folder Operation #2863

Closed
17 of 20 tasks
abelgardep opened this issue Apr 24, 2020 · 2 comments · Fixed by #3231
Closed
17 of 20 tasks

[New Arch] Rename file/folder Operation #2863

abelgardep opened this issue Apr 24, 2020 · 2 comments · Fixed by #3231
Assignees
@abelgardep
Labels
Estimation - 3 (M) New architecture
Milestone
3.0 - Synchroniza...

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Apr 24, 2020 •
edited
Loading

Synchronization epic: #2818

AC:

  • Every item can be renamed
  • Name must not be already used
  • Characters "/" and "\" are forbidden
  • Other errors:
    • No connectivity
    • Server not reached
    • Maintenance mode...

TASKS

  • Research (if needed)
  • Create branch new_sync/rename
  • Development tasks
    • Create new usecase -> RenameFileUseCase
    • Add renameFile to repository
    • Add renameFile to RemoteDataSource (Call CheckRemotePath before RenameRemoteFileOperation to check if folder already exists?)
    • Migrate RenameRemoteFileOperation to kotlin
    • Migrate Rename dialog to kotlin
    • Inject shared FilesViewModel into renamedialogfragment
    • Call rename usecase inside FilesViewModel
    • Observe rename result in FileDisplayActivity
    • Update new database with an updated name and its descendants
    • Update local file with an updated name and its descendants
    • Update DocumentsProvider
    • Error handling
    • Unit tests
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch new_sync/rename into new_arch/sync

PR
@davigonz davigonz mentioned this issue Apr 24, 2020
Closed
75 tasks
@jesmrec jesmrec added this to the Synchronization milestone milestone Jun 19, 2020
@jesmrec jesmrec added the Sprint label May 7, 2021
@abelgardep abelgardep self-assigned this May 7, 2021
@abelgardep abelgardep mentioned this issue May 11, 2021
Merged
@abelgardep abelgardep linked a pull request May 11, 2021 that will close this issue
[New arch] Rename #3231
Merged
@abelgardep abelgardep mentioned this issue May 11, 2021
Merged
@abelgardep
Copy link
Contributor Author

Blocked till #2865 is merged because we need to perform a MOVE operation to rename local files and save them in the database.

@abelgardep abelgardep mentioned this issue May 24, 2021
Merged
@abelgardep
Copy link
Contributor Author

Will be tested within the synchronization epic.

@jesmrec jesmrec removed the Sprint label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelgardep abelgardep

Labels
Estimation - 3 (M) New architecture
Projects
None yet
Milestone
3.0 - Synchronization milestone
Development

Successfully merging a pull request may close this issue.

[New arch] Rename owncloud/android
2 participants
@jesmrec @abelgardep