-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New arch] Rename #3231
Merged
Merged
[New arch] Rename #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
This was referenced May 11, 2021
abelgardep
changed the title
Add rename file to remote file datasource
[New arch] Rename
May 11, 2021
abelgardep
force-pushed
the
new_arch/rename
branch
from
May 19, 2021 14:27
01b1988
to
ea25d2a
Compare
abelgardep
force-pushed
the
new_arch/rename
branch
from
May 20, 2021 11:45
eebc507
to
0a11225
Compare
davigonz
reviewed
May 24, 2021
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/dialog/RenameFileDialogFragment.kt
Show resolved
Hide resolved
davigonz
approved these changes
May 24, 2021
Tests won't pass because there are some ktlint errors that were fixed in master. Tests will pass after a rebase with master. It will be done in the |
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #2863
Library PR (if needed): owncloud/android-library#399