[New arch] Remove file #3214
Merged
[New arch] Remove file #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
20 tasks
Base automatically changed from
new_arch/download_with_worker
to
new_arch/synchronization
April 30, 2021 11:48
abelgardep
force-pushed
the
new_arch/synchronization
branch
from
4b4e969 to
a30fea4
Compare
abelgardep
force-pushed
the
new_arch/remove_file
branch
from
60ab175 to
bedaf3e
Compare
…e step to preserve git history.
JuancaG05
reviewed
May 5, 2021
owncloudDomain/src/main/java/com/owncloud/android/domain/files/usecases/RemoveFileUseCase.kt
Show resolved
Hide resolved
davigonz
approved these changes
May 7, 2021
| if (file.isAvailableLocally) { | ||
| containsDown = true | ||
| } | ||
| // FIXME: 13/10/2020 : New_arch: Av.Offline |
There was a problem hiding this comment.
Maybe is better to use a TODO with a New arch tag so you can filter in the future what's pending? 🍻
There was a problem hiding this comment.
I introduced fixmes when we migrated the database, so I can filter them to check what's missing to move to the new arch. The idea is basically the same as TODOS, so I'll keep it this way since I already started using fixmes. Anyway, I will consider your proposal for future refactors 👍
...main/java/com/owncloud/android/presentation/ui/files/removefile/RemoveFilesDialogFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/files/removefile/RemoveFilesDialogFragment.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
Outdated
Show resolved
Hide resolved
abelgardep
force-pushed
the
new_arch/remove_file
branch
from
3ffae6b to
2686d8d
Compare
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Implements #2864
Library PR (if needed): owncloud/android-library#394