Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Open with action trigger an edit action #3499

Merged
merged 4 commits into from
Jan 19, 2022
Merged

[FEATURE REQUEST] Open with action trigger an edit action #3499

merged 4 commits into from
Jan 19, 2022

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Jan 13, 2022 •
edited by jesmrec
Loading

Related Issues

App: #3475

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3499-open_with_save.md

@JuancaG05 JuancaG05 self-assigned this Jan 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

abelgardep
abelgardep approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelgardep abelgardep linked an issue Jan 13, 2022 that may be closed by this pull request
[FEATURE REQUEST] Open with action trigger an edit action #3475
Closed
10 tasks
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 19, 2022

Some notes:

  • Only tested the Open with part. Whatever happens in the subsequent upload is not a matter of this PR. Issues like [BUG] Conflict appears with no modification in txt file #2921 are reproducible but are in the scope of [New Arch] Conflicts management #3005 and not here.

  • If the selected app to Open with implements the document provider, the fact of saving the new version of the file in oC will be delegated to such feature. Therefore, the most common scenario is saving a local copy inside the app storage or in any other location.

With this two comments, this is approved on my side. Great improvement!

@abelgardep abelgardep merged commit 23ff10d into master Jan 19, 2022
@abelgardep abelgardep deleted the feature/edit_action branch January 19, 2022 14:25
@JuancaG05 JuancaG05 mentioned this pull request Sep 23, 2022
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

@fesave fesave Awaiting requested review from fesave

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Open with action trigger an edit action
3 participants
@JuancaG05 @jesmrec @abelgardep