Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons needed for extremely popular shops [meta-issue] #1460

Closed
26 of 37 tasks
kocio-pl opened this issue Mar 23, 2015 · 28 comments
Closed
26 of 37 tasks

Icons needed for extremely popular shops [meta-issue] #1460

kocio-pl opened this issue Mar 23, 2015 · 28 comments

Comments

@kocio-pl
Copy link
Collaborator

kocio-pl commented Mar 23, 2015

We should start rendering extremely popular shop types (let's say above 10 000 uses on taginfo), but we probably have no icons for them:

Getting there (items above 5 000 uses):

Others (some useful items above 1 000 uses):

Some other (including super-star shop=kiosk), which already have the icons available, were proposed in #1402.

@nebulon42
Copy link
Contributor

We have for gift: gift-18.svg: gift-18

Regarding shop=hardware the distinction to shop=doityourself is not clearly defined, so I think for a start we could also use the DIY shop icon for that.

@kocio-pl
Copy link
Collaborator Author

OK, the gift icon is good and +1 for sharing the doityourself icon.

@nebulon42
Copy link
Contributor

Regarding shop=electronics I'm not sure (see also https://github.com/nebulon42/osmic/issues/17) which icon to choose. There are subtypes like computer, hifi, photo, etc. so none of those is suitable as icon. Ideas?

@kocio-pl
Copy link
Collaborator Author

If we avoid popular subtypes, which may be needed later, we would be left with some generic/iconic electronics like TV-set or a small radio with antenna. Taginfo may help a bit: according to http://taginfo.openstreetmap.org/keys/electronics_repair radio should be the safest choice, since it's not even mentioned and it's probably the oldest (=the least interesting) kind of electronics still used today (phone is rather "mobile phone" and photo is rather "digital photo" these days).

@nebulon42
Copy link
Contributor

Yes, TV and/or radio could actually work.

@nebulon42
Copy link
Contributor

@kocio-pl: Could you please update your list and cross out things that have been done already? This would make it easier to see what is still open.

@matthijsmelissen
Copy link
Collaborator

I added checkboxes. 1 and 3 should be checked, right?

I'm not sure if regular users can check/uncheck checkboxes?

@nebulon42
Copy link
Contributor

Thanks, yes that's fine. I can't check them here, but for my own comments as in #1165 I can.

@HolgerJeromin
Copy link
Contributor

Changing checkboxes is a normal edit in the background of github. So only the owner and repo maintainer is able to change the content.

@nebulon42
Copy link
Contributor

@kocio-pl shop=hardware doesn't currently have an icon, so this should be unchecked.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 3, 2015

Wasn't it your idea to use DIY icon? =}

@nebulon42
Copy link
Contributor

Idea yes, but it's not done yet. When checked we might think it is done while it isn't. I will make that PR after #1520 got decided, otherwise there will be certainly merge conflicts in one of them.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 3, 2015

OK, I see. Unchecked.

@SomeoneElseOSM
Copy link
Contributor

Just to provide a bit of external feedback, I noticed this on the forum:

http://forum.openstreetmap.org/viewtopic.php?pid=504204#p504204

I suspect that the effect that they're talking about is as seen here at z17:

http://www.openstreetmap.org/#map=17/52.95354/-1.14638

(I'm not convinced that it's a "problem" per se; just trying to link to some feedback).

EDIT: Actually, it turns out that the forum poster was referring to Garmin maps, not OSM-carto ones. Sorry for the noise!

@nebulon42
Copy link
Contributor

Probably we should start discussing if we should render some POIs later on. For shops we could also switch from a two-tier (supermarkets etc. earlier and everything later) to a three-tier rendering. It may be good to have a separate issue for that.

@kocio-pl
Copy link
Collaborator Author

I think it really is a problem, but much more general: we have a threshold for rendering some POIs (or other elements), but since we have no objects density metric available, some places will be overloaded, while at the same time other ones will be almost blank with the same style.

There was similar discussion about footways: in the city, in cemetery or in allotments red dotted lines can be quite disturbing on some zoom levels, but in remote places (in the forest, in the mountains and the like) they can be even the most important thing for the users to see.

To some degree we could deal with it better if we render some regions (countries, cities...) in a different way, but developers choice is that style should be uniform for the whole planet.

@nebulon42
Copy link
Contributor

I still opened #1560 for that.

@kocio-pl
Copy link
Collaborator Author

Currently I don't see the possibility to add much more icons to this style and all the most important ones (10k+) are now rendered, so I close this issue. However it can still play the role of cheat sheet for adding some other interesting/popular shop types in the future.

@matthijsmelissen
Copy link
Collaborator

Thanks for all your work!

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jun 19, 2016

Interesting icon was proposed for shop=deli, what do you think about it?

http://wiki.openstreetmap.org/wiki/File:Shop_deli.svg

@dieterdreist
Copy link

sent from a phone

Il giorno 19 giu 2016, alle ore 15:52, kocio-pl [email protected] ha scritto:

what do you think about it?

I can understand it, if I am told what it's meant to be, but otherwise I'd see it more for shop=seafood

@daganzdaanda
Copy link

Used at the size of the map icons, I believe that it won't be readable.

@kocio-pl
Copy link
Collaborator Author

Look at the "proposed" link - it looks quite good there.

@Jotam
Copy link

Jotam commented Jul 13, 2016

I'm the one who submitted the proposition for shop=deli. I chose a lobster because I believe it to be a generally recognized synonym for luxurious food.

In my opinion, shop=seafood should be rendered with the more generic fish symbol. That's also what they do on Mapnik (see here: https://wiki.openstreetmap.org/wiki/Tag:shop%3Dseafood#Rendering)

@kocio-pl
Copy link
Collaborator Author

Just the remark: there is no map layer called "Mapnik", because it's just a name of the rendering software which is used with different styles. This one is called "osm-carto" in short and it would be good to fix the naming on the wiki one day.

So "we" not "them"... ;-) But you're rightt, we use fish symbol here since my proposition (#1617) has been merged.

@kocio-pl
Copy link
Collaborator Author

@Jotam What about something like jar?

@Jotam
Copy link

Jotam commented Aug 18, 2016

In my opinion, the jar looks like a sweet shop. I never quite understood why it was used for shop=deli.

When I think about it, the lobster is still the first thing that comes to my mind when talking about luxurious food.

I see why one might say it could stand for seafood. But then, any icon you could possibly think of for a deli could stand for something else. Like the jar for sweets, a ham for a butcher, a cheese for a cheese shop, or a bottle of champagne for a beverage shop. (Also see example pic on the wiki for a typical deli: https://wiki.openstreetmap.org/wiki/File:Rome_Italian_deli.jpg)

@kocio-pl Could you try to render the lobster and share the results here? Thanks a lot!

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 18, 2016

For me jar would be good, especially with the visible hood, which for me is a symbol of exclusive, hand crafted item (it hints "deli" articles in convenience shops I visit):

http://pl.depositphotos.com/5893158/stock-illustration-jar-of-jam.html

Another idea would be to show certification badge on a piece of fine food, but I guess we have too few pixels to show both - unless you think the badge alone would be sufficient:

https://www.iconfinder.com/icons/201277/award_badge_prize_quality_ribbon_sticker_icon

Maybe just this kind of ribbon in the front of a piece of fine food would be good:

https://www.iconfinder.com/icons/1365686/army_award_badge_military_soldier_war_icon#size=128

Or maybe take the alcohol shop icon and replace a glass with an oyster.

Sure, I'll make this rendering and will post it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants