-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for shop=funeral_directors #2355
Comments
Thank you for opening this ticket! I guess this icon does not work standalone (only as an element of cemetery pattern) and is somehow similar to memorial icon. However I was thinking about it for months and I guess simple grave candle like this would be OK. Maybe coffin shape could work too, but it's probably hard to avoid cross on it to make it more recognizable, and that wouldn't be so universal then. |
FWIW elsewhere I went with https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/blob/master/symbols/shop_funeraldirectors.p.16.png - but as you say with a cross on it it's really not universal. |
@kocio-pl I know you think it doesn't work but could you please render it anyway? Thanks |
Looks like the perfect icon for a candle shop! ;) |
With moderate usage and being a very specialised shop, I'm inclined towards not rendering with its own icon. |
It has more than the art, tea and tobacco shops, and almost the same deli - all of which have been discussed recently and PRs submitted. What level of usage would it need to get rendered? |
2016-09-23 11:49 GMT+02:00 Paul Norman [email protected]:
why would we not want to show specialised shops? Millions of people are |
I notice shop=bag, hifi, musical_instrument, outdoor, and seafood are all rendered but are used less than funeral_directors, and arguably just as specialised. Is there any difference in priority given to a shop tag rendered with its own icon than one with a dot in a crowded area? If not then what is the problem with icons for lesser used shop tags, since they will just be replacing a dot? |
I also don't understand why do you consider them "specialized" - I feel they are very generic. For me specialized could mean mobile phone (subclass of shop=electronics) or cheese (subclass of shop=food). What more general category do you see for this one? Or how do you define the term "specialized"? shop=funeral_directors is one of the most typical "shops" we don't show now (or don't do it clearly) - like clockmaster, tax office, electronic repair, tailor, lawyer etc. Some of them have a lot of uses, while others are rare in our database, and we have a database limitation excluding some of the keys. That's just tagging or technical problem we have to deal with, but this tag has no such issues. So I don't see the reasons against showing this icon. |
I don't see a hard cutoff when the decision needs to change. When looking at the map to see what is around you, I see the generic dot rendering as sufficient. I don't regard someone looking at the map to find a funeral directors as a significant usecase. |
sent from a phone
this can be said for anything, especially if no reasoning is given. Anything shown in the map is suitable for orientation anyway, if it is visible in the real world |
As I said few times already, I don't expect to find things on this map, rather to explain the space. Finding POIs is a job for app like OsmAnd or other specialized service. |
I would like to see funeral directors rendered in their specific way. But I admit it is also hard to find a suitable icon. Funeral rites are extremely diverse across cultures. The cross is certainly not the perfect choice. And a tomb stone would suggest there is ... mmh ... well ... a tomb. What about a coffin? That is pretty universal (although not entirely of course). |
Another try (by @MaestroGlanz): What do you think about it? |
I dont think dead muslime people are burried in a box with a cross on it :) |
I support that too ;) @HolgerJeromin But what would you suggest? |
What about something like this (without the cross on top, I think): |
It would look like a car shop. |
IMHO the car without the cross doesn't work at all. The more I think about it, the more I'm convinced that finding an icon that would depict all cultures worldwide is next to impossible. Funeral rites are extremely diverse. |
https://taginfo.openstreetmap.org/tags/?key=shop&value=funeral_directors#map is showing it across the world, including high presence in Japan |
Okay, I admit Japan is a bit of problem there. However, it seems to me that 99% of the rest of funeral directors are based in countries that have a predominantly Christian heritage. This goes of course for all of Europe, the US, Australia, Latin American as well as African countries. And the big chunk in the South China See are the Philippines, which are the biggest Christian country in Asia. So maybe the cross symbol would be okay for the (by far) biggest part of the world. |
Thanks for asking this question and for checking it! I would rather avoid religion symbols. It's not always easy - we stucked with cross for hostpitals and similar items, because general symbol exists, but who heard about "red crystal"? For funeral there can be less loaded symbols, even if truly universal one is not possible to find, and I still think that coffin shape might be of use. |
Re gravestone, I'm not convinced that's culturally neutral either (nor is a "funeral car" or even a coffin), but an outline coffin shape is probably the least worst option of what's been suggested so far (including mine). |
Great, it still looks good for me! So - anybody willing to make a PR and test rendering? |
I can do the PR. But I don't have a testing environment for rendering. Someone should do this before the PR! |
That's why we have a Docker environment: https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md If you have Windows or macOS you may have problems installing Docker (especially with not the latest OS versions), but I would advise to just run VirtualBox with Linux inside and install Docker inside it. I can help you with that if you want. |
@Jotam then you could list it in the OSM-Wiki, like mine: |
Great, I see that you have managed to set the environment! Could you prepare the pull request? |
As discussed here: gravitystorm#2355 (comment)
PR for the SVG file created. |
Sorry but there should not be a cross on the coffin unless it is explicitly marked as religion=christian. A funeral director's shop, in the UK anyway, is normally secular - if someone wants a religious funeral or service it is then arranged with the local place of worship as part of the service provided by the funeral director. |
A cross is a recognizable symbol for the death / graves - just like a phone horn represents calling even on devices without horn. |
We are very careful with symbols and that's why it takes a lot of time to find them sometimes, like in this case. But there are many cases when there is hard to find symbols not related to religious background - or they exist, but would be not recognizable (ever heard about "red crystal" for example?). |
👎 for a cross. The symbol also seems a bit heavy in relation to those around it. I'm still 👎 the idea of rendering it with its own symbol, for the reasons above. |
This shop is rendered - just not with a special icon. I agree with @pnorman that none of proposed icons work and it is really unlikely that we will find fitting one, so I would propose to close - and welcome PR that would solve this issue (though I am not expecting that it is fixable). |
We have cross in hospital, doctors, pharmacy and veterinary outside the religious objects. I can think of changing hospital cross into hotel bed icon (with health color and in the circle, of course, probably also mirrored to make additional difference), but with the rest it's hard to get rid of the cross. We should try (and we did here), but if there's no good alternative, it's reasonable to use what works mostly. I feel #2355 (comment) is a correct description of the problem. |
I absolutely agree with @kocio-pl. We have indeed discussed many different options. But this simply is the best in terms of recognizability. |
Note that the christian cross and the medical one have different shapes (different vs same length of the bars), thus please don't mix them. On cemeteries/graveyards we explicitly use the christian cross if religion is set accordingly, in contrast to a tombstone if not. |
Again, this is not a Christian cross in the sense that it is a religious symbol. It's just a (almost) universal symbol for death. |
Can you provide some evidence for such universality across cultures? |
If you don't want a cross, I see a lot of Halloween-related icons put a horizontal line through the widest part of the coffin. For some reason, that makes it look more coffin-like. |
Could you show us how would it look like? |
@ArcticGnome Do you plan to give it a try? |
I'm worried that any symbol (all of them are connected with religion/ cemetery/ death) put in shop-violet would look bad. Default dot in enough for me in this case. |
I was thinking about brown because of that. |
But then it may be confusing, and seen as some amenity instead of shop. |
I have proposed once to render violet only shops selling physical objects, while shops selling services (like travel agent, hairdresser or funeral directors) would be rendered in brown. I still think this is good idea. |
As we didn't find consensus about proper icon for this feature, I propose to stay with dot-rendering and close this issue. |
OK, I give up for now, might be reopen if needed. |
Noticed the iD editor has an icon for this, but it's not rendered here. The tag has over 7000 uses: http://taginfo.openstreetmap.org/tags/?key=shop&value=funeral_directors
The gravestone/cemetery icon is available here: https://github.com/bhousel/maki/blob/mb-pages/src/cemetery-24.svg
The text was updated successfully, but these errors were encountered: