Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon for shop=funeral_directors #2979

Closed
wants to merge 2 commits into from
Closed

Conversation

Jotam
Copy link

@Jotam Jotam commented Dec 11, 2017

This is a replacement / correction for PR #2968

File reworked to avoid Inkscape meta data.
See comments here: gravitystorm#2968
To include new icon for shop=funeral_directors
@kocio-pl
Copy link
Collaborator

Thanks, that's better, but you still need to edit the project.mml (where the specific data are selected from database) and it would be good if you test the rendering. BTW: how did you make the image in #2355 (comment)?

You can see an example of the latest merging of shop=tyres (this would be quite similar, as shops are very typical in osm-carto):

https://github.com/gravitystorm/openstreetmap-carto/pull/2706/files

You should also add the line "Resolves #2355" to this ticket, so the issue would be automatically closed on merging this PR.

@Jotam
Copy link
Author

Jotam commented Dec 15, 2017

you still need to edit the project.mml

Sorry guys, I really lack the time to dig deeper into all of this. Could someone do this who already knows the drill and therefore won't waste a lot of time? Thank you!

@kocio-pl
Copy link
Collaborator

OK, but the discussion about proposed shape is still pending in #2355, so there's no hurry.

@kocio-pl
Copy link
Collaborator

Thanks for trying, but this code is both incomplete for a long time and the design is not popular enough among community. Therefore I will close it now.

@kocio-pl kocio-pl closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants