Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=interior_decoration #1406

Closed
kocio-pl opened this issue Mar 18, 2015 · 29 comments · Fixed by #3293
Closed

Add special rendering for shop=interior_decoration #1406

kocio-pl opened this issue Mar 18, 2015 · 29 comments · Fixed by #3293

Comments

@kocio-pl
Copy link
Collaborator

We should start rendering shop=furniture and shop=interior_decoration, probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/furniture.svg

[It was proposed in meta-issue #1402]

@kocio-pl kocio-pl changed the title Add rendering for shop=furniture and shop=interior_decoration Add special rendering for shop=furniture and shop=interior_decoration Mar 18, 2015
@nebulon42
Copy link
Contributor

furniture-18.svg: furniture-18

@kocio-pl
Copy link
Collaborator Author

Very nice!

@nebulon42
Copy link
Contributor

What is the distinction to interior_decoration? Should both get the same icon?

@kocio-pl
Copy link
Collaborator Author

Probably the same, OSM Wiki does not have definition for interior decoration shops (about 2,5 thousand uses) and looking at Wikipedia it's probably wider category than just furnitures, but don't know how to express it visually and the furniture can be a good symbol for all of it IMO.

@matkoniecz
Copy link
Contributor

What is the distinction to interior_decoration?

My guess is that interior_decoration may include also things like paints, tiles, paintings, deer head busts, lamps, stained glass etc.

Should both get the same icon?

Probably yes.

@dieterdreist
Copy link

Am 21.04.2015 um 00:27 schrieb kocio-pl [email protected]:

Probably the same, OSM Wiki does not have definition for interior decoration shops (about 2,5 thousand uses) and looking at Wikipedia it's probably wider category than just furnitures, but don't know how to express it visually and the furniture can be a good symbol for all of it IMO.

the word sounds more like living accessories than furniture

@pnorman
Copy link
Collaborator

pnorman commented Apr 22, 2015

I wouldn't render them as the same symbol.

@kocio-pl
Copy link
Collaborator Author

Do you have any idea what symbol could it be? Curtains with lamp? Frame and something? I guess one item would be not general enough for such a broad category as interior decorations.

@pnorman
Copy link
Collaborator

pnorman commented Apr 23, 2015

I can't think of one, so I'd just leave it as the default symbol.

@dieterdreist
Copy link

2015-04-23 1:51 GMT+02:00 Paul Norman [email protected]:

I wouldn't render them as the same symbol.

+1, maybe a flower vase and another living item (curtains?)

@nebulon42
Copy link
Contributor

I want to avoid a vase, since I'd like to use that for archaelogical sites. Since interior decoration is not too popular I will not concentrate on a distinct symbol for that right now.

@dieterdreist
Copy link

2015-04-23 16:27 GMT+02:00 nebulon42 [email protected]:

I want to avoid a vase, since I'd like to use that for archaelogical sites.

I'd use an amphora there (different shape)

@matthijsmelissen matthijsmelissen added this to the New features milestone Apr 29, 2015
@kocio-pl
Copy link
Collaborator Author

I guess curtains would be the best for shop=interior_decoration.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 2, 2015

What about something like this:
1) interior_decorations-14-3

@matkoniecz
Copy link
Contributor

Sorry, but this one is not obvious.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 4, 2015

  1. interior_decoration-14-6

@matkoniecz
Copy link
Contributor

@kocio-pl Can you mention or somehow mark in the issue description that shop=furniture now has its own icon?

@kocio-pl kocio-pl changed the title Add special rendering for shop=furniture and shop=interior_decoration Add special rendering for shop=interior_decoration Aug 26, 2015
@kocio-pl
Copy link
Collaborator Author

Sure, done.

@Jotam
Copy link

Jotam commented Aug 18, 2016

I think interior decoration is definitely different from furniture. Decoration shops sell smaller items which have a primarily decorative purpose. Like vases, candles, small lamps, table cloths, etc. They shouldn't have the same icon, imho. Maybe a lustre / chandelier would work...?

@kocio-pl
Copy link
Collaborator Author

I have tried the chandelier but got no reaction. For me it was great as a proof of concept, but this particular shape turned out to be my failure as a designer - could you draw a better one? We're getting to 6k uses, so it's worth trying.

@kocio-pl
Copy link
Collaborator Author

I'm currently not planning to add more shop icons and we have them for most of our 10k+ shops (this one is still below that line), so it can be reopened if someone is able to propose a design that is acceptable.

@lakedistrictOSM
Copy link

Now on 9.7k uses. Finding an icon that would work is difficult because these shops sell such a wide range of different things.

The English wiki doesn't have a proper definition although the German wiki lists "accessories, tableware, porcelain, small items of furniture, designer pieces, different styles and more." I tend to tag shops that sell (primarily) decorative items for within a home as shop=interior_decoration and shops that sell more functional/useful household items as shop=houseware.

Maybe a lamp, cushion, ornament or candle icon would work? Any ideas @Tomasz-W?

@Tomasz-W
Copy link

I'll try with lamp + picture/ flower.

@Tomasz-W
Copy link

Icon proposal (lamp + flower):

shop interior_decoration

@kocio-pl
Copy link
Collaborator Author

Lamp foot should be bigger and maybe you could add a thin pulling switch, but it's already very nice - I'm surprised, especially after my countless tries...

@kocio-pl kocio-pl reopened this Mar 22, 2018
@Jotam
Copy link

Jotam commented Mar 22, 2018

I like the general idea. I think the flower could be a bit bigger and the pot should be a little smaller. Other than that: Great!

@Jotam
Copy link

Jotam commented Mar 22, 2018

@kocio-pl I agree about the lamp foot. But I'm not sure a pulling switch would be recognizable.

@lakedistrictOSM
Copy link

Looks good! Only change I'd make is to thicken/widen the lamp base.

@Tomasz-W
Copy link

shop=interior_decoration v2:
shop interior_decoration

Gist link: https://gist.github.com/Tomasz-W/ffabda18674552410876fa21421fcd1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants