Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=car_parts #1537

Closed
kocio-pl opened this issue May 7, 2015 · 16 comments · Fixed by #1581
Closed

Add special rendering for shop=car_parts #1537

kocio-pl opened this issue May 7, 2015 · 16 comments · Fixed by #1581

Comments

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2015

  1. My proposition for this kind of shop: car_parts-14

[Mentioned on meta-issue #1460]

@matkoniecz
Copy link
Contributor

This icon is not really working for me.

@matkoniecz matkoniecz added this to the Bugs and improvements milestone May 7, 2015
@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 7, 2015

One-man survey indicated it would be a scrap, however it's far in the queue for adoption (about 0,1k...). I was expecting that may be too distant association, so - back to reality:

  1. car_parts-14-2
  2. car_parts-14-3
  3. car_parts-14-4

@marcgemis
Copy link

what about a car exhaust or shock absorber ? would that be doable on such a small space ?
I wonder whether I would recognize 2 as a wheel on a map.
and 3 is pretty close to the icon of Mercedes , not ?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 8, 2015

I doubt car exhaust or shock absorber would work - maybe some photos/icons showing their shape could help here? Another idea is to use spark plug or headlamp, but the first one will be probably too geometric, and lamps have many shapes, not always easy to recognize.

Maybe old car horn (like this or this) would do, because the shape is great, but I have to try if it fits so small matrix well enough.

@brycenesbitt
Copy link

I like the car door.

But really: there are many features that should come first.

@yohanboniface
Copy link

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 9, 2015

@yohanboniface Wow, that was great, thanks a lot! =} How did you get this brilliant idea?

So - shameless copy with bold, thin or medium sized signs?:
5) car_parts-14-8
6) car_parts-14-6
7) car_parts-14-7

I guess I have to test it with real style to know. 5) looks too prominent now, but with different color and among other symbols on the map it may be actually very good!

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 9, 2015

@brycenesbitt

But really: there are many features that should come first.

What do you mean exactly?

I don't have any particular order for designing icons, I just made a list of the most popular tags with no icon yet (plus one with possible icons from French style) and try a lot, especially when the comments are mostly negative, until it works or I get stuck. But after that I plan to also draw sketches for other easy/important items ("important objects" not always mean "big quantities"). Do you have any candidates?

@daganzdaanda
Copy link

The door looked nice, but a car battery really makes more sense for this kind of shop.
I'd go with No. 6.

@AndiG88
Copy link

AndiG88 commented May 17, 2015

With electric cars becoming more popular I'm not sure a battery is the best solution.

http://www.greencarreports.com/news/1096570_about-that-one-tesla-battery-swapping-station-an-update

@daganzdaanda
Copy link

Hm, yeah, these might become popular in a few years (the example from the link is not open to the public yet). But should we really reserve this icon for future use? Would you then prefer the car door for "car_parts"?

Btw, for idea 2) there is also http://wiki.openstreetmap.org/wiki/Tag:shop%3Dtyres with 5000+ objects.

@kocio-pl
Copy link
Collaborator Author

Thanks - so I would definitely reserve kind of 2) for tyres, but don't know what objects would we need for electric cars. Maybe they can be better depicted the other way?

@kocio-pl
Copy link
Collaborator Author

The proposition for electric cars charging station is here and looks like a fuel station, so battery is still the best for car parts, I think.

@kocio-pl
Copy link
Collaborator Author

Real life test:

car_parts-large-after-z19

car_parts-small-after-z19

I prefer the first one, because it's a bit lighter and more crisp, but the second one is not as dark (solid) as I was afraid.

@daganzdaanda
Copy link

I'm fine with both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants