Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=tobacco and shop=e-cigarette #1618

Closed
kocio-pl opened this issue Jun 24, 2015 · 14 comments
Closed

Add special rendering for shop=tobacco and shop=e-cigarette #1618

kocio-pl opened this issue Jun 24, 2015 · 14 comments

Comments

@kocio-pl
Copy link
Collaborator

First sketch is straightforward, but may work well for both types:
1) tobacco-14-1

@lest69
Copy link

lest69 commented Jun 24, 2015

It's recognizable for me.

@kocio-pl
Copy link
Collaborator Author

We should decide if we want it just for shop=tobacco or maybe for shop=e-cigarette too, since the later is just proposed on Wiki and is used only 304 times. However I'm not aware of any osm-carto policy regarding Wiki or Taginfo and we may decide differently if we think it makes sense.

@kocio-pl
Copy link
Collaborator Author

Small variation:
2) tobacco-14-2

@dieterdreist
Copy link

sent from a phone

Am 25.06.2015 um 13:25 schrieb kocio-pl [email protected]:

decide if we want it just for shop=tobacco or maybe for shop=e-cigarette too

around here these are distinct shops, and the smokers won't find what they need at a vaporizer shop and the people inhaling vapors won't want stuff that burns and smokes.
Pharmacies are selling nicotine products as well, but we don't render them as tobacco shops ;-)

@kocio-pl
Copy link
Collaborator Author

In real life the distinction between many types of shops are more or less shady, even when we think it should be clear (convenience can be like groceries+newsagent+cafe...). Also when you look for a shoes, it is different when you're a women and need some fashion shoes instead of general ones, but currently we're agnostic regarding it and show men's shoe icon.

On some level tobacco and e-cigarettes are both "for smokers" and they can use the same icon to give you a hint what kind of shop is it: not necessary the exact type, because - as I said few times already in the past - icons are just the abstract hints hiding many details by design.

@dieterdreist
Copy link

sent from a phone

Am 26.06.2015 um 17:02 schrieb kocio-pl [email protected]:

On some level tobacco and e-cigarettes are both "for smokers" and they can use the same icon to give you a hint what kind of shop is it: not necessary the exact type,

this was also discussed on tagging, both are shops dedicated to nicotine addicts, but vapor is not "smoke", neither technically nor legally.

@kocio-pl
Copy link
Collaborator Author

OK, so I have no problem leaving e-cigarettes for have some other icon - one day maybe - and stick with this icon to just tobacco shops (once we manage to make some agreement about new icons <5k uses with @math1985).

@yarl
Copy link

yarl commented Jun 29, 2015

What about cigarettes vending machines? Over 11k usages.

@kocio-pl
Copy link
Collaborator Author

We have no rule for vending machines yet. I rather think it's more interesting for the typical user to know what she can buy or do there (like laundry or post terminals) than if it's a regular shop or just a machine, so it makes sense to me to show them too, but it probably depends on database reload (to have vending=* key available).

@kocio-pl
Copy link
Collaborator Author

Do we really don't want shop=e-cigarette to not have the same icon as shop=tobacco? If so, I would close this issue.

@dieterdreist
Copy link

2016-09-21 0:12 GMT+02:00 kocio-pl [email protected]:

Do we really don't want shop=e-cigarette to not have the same icon as
shop=tobacco? If so, I would close this issue.

e-cigarette shop are different shops in that they often don't sell common
tobacco / cigarettes, therefor it would make sense for customers to be able
to distinguish them on the map.

@kocio-pl
Copy link
Collaborator Author

On the other hand I can't think of any special shape for e-cigarette shop - for me it's rather all "for smokers", whether it's this way or the other and that's the level of abstraction I feel it. I also suspect that some e-cigarette shops may be mistagged as a shop=tobacco. Wiki page says "Use shop=e-cigarette for shops that sell only electronic cigarettes", so when they are mixed, I would made it shop=tobacco as more general category with new subtype included.

Still the e-cigarette tag is still not popular enough, despite having its own wiki page, and current trend tells that it needs a long time to catch up with 2k+ uses, so that's a future problem and I will close this issue for now - it can be reopened any time later.

taghistory 1

@HolgerJeromin
Copy link
Contributor

@kocio-pl could you try the tabacco icon without the ash part for e-cigarette? I mean a solid line. perhaps too subtle, but perhaps worth a try.

@kocio-pl
Copy link
Collaborator Author

Sure:

  1. tobacco-14-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants