-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special rendering for shop=tobacco and shop=e-cigarette #1618
Comments
It's recognizable for me. |
We should decide if we want it just for shop=tobacco or maybe for shop=e-cigarette too, since the later is just proposed on Wiki and is used only 304 times. However I'm not aware of any osm-carto policy regarding Wiki or Taginfo and we may decide differently if we think it makes sense. |
sent from a phone
around here these are distinct shops, and the smokers won't find what they need at a vaporizer shop and the people inhaling vapors won't want stuff that burns and smokes. |
In real life the distinction between many types of shops are more or less shady, even when we think it should be clear (convenience can be like groceries+newsagent+cafe...). Also when you look for a shoes, it is different when you're a women and need some fashion shoes instead of general ones, but currently we're agnostic regarding it and show men's shoe icon. On some level tobacco and e-cigarettes are both "for smokers" and they can use the same icon to give you a hint what kind of shop is it: not necessary the exact type, because - as I said few times already in the past - icons are just the abstract hints hiding many details by design. |
sent from a phone
this was also discussed on tagging, both are shops dedicated to nicotine addicts, but vapor is not "smoke", neither technically nor legally. |
OK, so I have no problem leaving e-cigarettes for have some other icon - one day maybe - and stick with this icon to just tobacco shops (once we manage to make some agreement about new icons <5k uses with @math1985). |
What about cigarettes vending machines? Over 11k usages. |
We have no rule for vending machines yet. I rather think it's more interesting for the typical user to know what she can buy or do there (like laundry or post terminals) than if it's a regular shop or just a machine, so it makes sense to me to show them too, but it probably depends on database reload (to have vending=* key available). |
Do we really don't want shop=e-cigarette to not have the same icon as shop=tobacco? If so, I would close this issue. |
2016-09-21 0:12 GMT+02:00 kocio-pl [email protected]:
e-cigarette shop are different shops in that they often don't sell common |
On the other hand I can't think of any special shape for e-cigarette shop - for me it's rather all "for smokers", whether it's this way or the other and that's the level of abstraction I feel it. I also suspect that some e-cigarette shops may be mistagged as a shop=tobacco. Wiki page says "Use shop=e-cigarette for shops that sell only electronic cigarettes", so when they are mixed, I would made it shop=tobacco as more general category with new subtype included. Still the e-cigarette tag is still not popular enough, despite having its own wiki page, and current trend tells that it needs a long time to catch up with 2k+ uses, so that's a future problem and I will close this issue for now - it can be reopened any time later. |
@kocio-pl could you try the tabacco icon without the ash part for e-cigarette? I mean a solid line. perhaps too subtle, but perhaps worth a try. |
First sketch is straightforward, but may work well for both types:
1)
The text was updated successfully, but these errors were encountered: