Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=kiosk #1459

Closed
kocio-pl opened this issue Mar 23, 2015 · 12 comments · Fixed by #1584
Closed

Add special rendering for shop=kiosk #1459

kocio-pl opened this issue Mar 23, 2015 · 12 comments · Fixed by #1584

Comments

@kocio-pl
Copy link
Collaborator

We should start rendering shop=kiosk (over 45k objects on taginfo), probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/kiosk.svg

[It was proposed in meta-issue #1402]

@nebulon42
Copy link
Contributor

kiosk-14.svg: kiosk-18

@kocio-pl
Copy link
Collaborator Author

I could not recognize it probably (for me it looks now like an oven covered with bananas... =} ). I'm not sure what to do, but maybe just removing the top bar could help? I can think also that the roof part can be made simpler (just those hanging elements?).

BTW: I'd like to start creating icons myself with Inkscape. What are the most important tips for making them pixel-aligned?

@nebulon42
Copy link
Contributor

For a start you could take the kiosk icon and try to improve it. :) Pixel-aligned means that the nodes of the path are snapped to the grid. Bring up the grid in Inkscape by pressing '#' and compare where the nodes are located. See also #632.

@kocio-pl
Copy link
Collaborator Author

I may start with the clinic, since I'm not too familiar with vector graphics. =}

I think basic guidelines regarding pixel-aligning could be added here:
https://github.com/nebulon42/osmic/blob/master/CONTRIBUTING.md#technical-aspects

@kocio-pl
Copy link
Collaborator Author

My proposition for kiosk: kiosk-14-building

@matthijsmelissen
Copy link
Collaborator

I think @nebulon42's version is clearer.

@matkoniecz
Copy link
Contributor

I prefer @kocio-pl's version so it may be cultural thing (typical kiosk style in a given area). Note that I tested neither on a map, it is based just on looking at svgs.

@kocio-pl
Copy link
Collaborator Author

I was not fully satisfied with my take, it was just a first try to make something more simple than Osmic. @nebulon42 has a lot of creative ideas when drawing the icons, but sometimes it hurts recognizability too bad for my taste and kiosk was beyond my power to stay calm. ;-)

Here is my second try, I guess more distinct from the general building: kiosk-14

@kocio-pl
Copy link
Collaborator Author

Some more sketches - this time inspired by French icon:

  1. kiosk-14-person
  2. kiosk-14-person-osmic
  3. kiosk-14-person-osmic-2
  4. kiosk-14-person-osmic-3
  5. kiosk-14-person-osmic-4
  6. kiosk-14-person-osmic-5

I guess for me it could be 4) or the building from above. Any suggestions?

@pnorman
Copy link
Collaborator

pnorman commented May 1, 2015

I'd rather not render using any of those. They look very shelter-like to me.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 1, 2015

So next delivery is less shelter-like and use the window metaphor instead:
7) kiosk-14-person-window
8) kiosk-14-person-window-2
9) kiosk-14-person-window-3
10) kiosk-14-person-window-4
11) kiosk-14-person-window-5

What about them? I don't think they are ready for instant use, but maybe one of them is a reasonable base for modifications or there are some good elements that can be used?

For me 4) is still preferable, because we want to show it's a stand-alone building so it should look a bit like a shelter. 11) is good enough, but for me it's rather ticket window/box office (shop=ticket, 1 471 uses -> 30x less important =} ).

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented May 1, 2015

Different metaphor now (should be suitable also for shop=newsagent which has another big number - 8 788 - of uses):
12) newspaper-14-2-12
13) newspaper-14-3-13
14) newspaper-14-2-14
15) newspaper-14-2-15
16) newspaper-14-2-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants