Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move DIY shop to SVG #1380

Merged
merged 1 commit into from
Mar 21, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.

before
diy_before

after
diy_after

(this particular shop is tagged incorrectly, but nevertheless useful as preview)

@nebulon42 nebulon42 mentioned this pull request Mar 14, 2015
66 tasks
@matkoniecz
Copy link
Contributor

In that case I am not recognizing new symbol on the right. Is it a soldering iron?

@nebulon42
Copy link
Contributor Author

Yes, that is a bit tricky :). It should be a screwdriver.

@matthijsmelissen
Copy link
Collaborator

A nut might also be a possible visualization.

@kocio-pl
Copy link
Collaborator

For me it's 50/50 - I'm not sure if I would recognize it not knowing what this icon represents. For me it's also too "square" (like new hairdresser proposition).

@HolgerJeromin
Copy link
Contributor

probably the hammer could be rounder on one side.

@neiljp
Copy link

neiljp commented Mar 15, 2015

While I really do appreciate the new designs and idea of transitioning to SVG, sometimes the older designs just do work better, for me at least.
IMO the previous 'claw' hammer design was definitely more distinctive and DIY-like.
I suppose DIY can imply electrical, so a screwdriver could be valid, but a spanner is a more recognisable and drawable shape.

@pnorman
Copy link
Collaborator

pnorman commented Mar 17, 2015

I prefer the old one also.

@matkoniecz
Copy link
Contributor

It should be a screwdriver.

Unfortunately it is not recognizable. Can you try something different for tool on the right?

@nebulon42
Copy link
Contributor Author

What about this alternative? doityourself-183

@matkoniecz
Copy link
Contributor

I like it.

@kocio-pl
Copy link
Collaborator

It's better now, but I would still like the right one's head to be more distinctive (maybe body slimming would be enough).

@nebulon42
Copy link
Contributor Author

This is the most I could get out of it: doityourself-183

More is not possible.

@matthijsmelissen
Copy link
Collaborator

Much better. Maybe the hammer would be clearer without the top pixel?

What about the bolt idea? Something like this?

bolt

@nebulon42
Copy link
Contributor Author

I somehow prefer the top-stuff added even if it is slightly blurrier. Without: doityourself-183

If you mean depicting the bolt like that: It is (almost) square which makes it difficult to depict alongside the hammer. Either it will be too small or too wide.

@matthijsmelissen
Copy link
Collaborator

No, I meant the bolt on its own. Not sure if it's iconic enough to be recognizable as DIY though.

@nebulon42
Copy link
Contributor Author

@math1985 While I find the use of one symbol rather than two desirable I'm not sure if this would be recognisable enough. For simplicity reasons I decided to stick with the icon which I already had.

Updated. From my side this is now ready.

matthijsmelissen added a commit that referenced this pull request Mar 21, 2015
@matthijsmelissen matthijsmelissen merged commit c0dcfb8 into gravitystorm:master Mar 21, 2015
@nebulon42 nebulon42 deleted the svg-diy branch March 21, 2015 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants