Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=musical_instrument #1420

Closed
kocio-pl opened this issue Mar 18, 2015 · 17 comments
Closed

Add special rendering for shop=musical_instrument #1420

kocio-pl opened this issue Mar 18, 2015 · 17 comments

Comments

@kocio-pl
Copy link
Collaborator

We should start rendering shop=musical_instrument, probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/musical_instrument.svg

[It was proposed in meta-issue #1402]

@nebulon42
Copy link
Contributor

This icon is already in use for amenity=nightclub.

@kocio-pl
Copy link
Collaborator Author

I think it could be more specific - like guitar or piano. But wasn't it disco ball that we were trying to apply here or was it some other tag?

@kocio-pl
Copy link
Collaborator Author

My proposition:
1) musical_instrument-14-4

@lest69
Copy link

lest69 commented Jun 24, 2015

I know what it's supposed to be, but I'm concerned it could be confused with other things (shoe, ice skate, cleats, etc.). Can you maybe try a guitar?

@kocio-pl
Copy link
Collaborator Author

That was what I started with, but the result was rather poor, so I'm still trying:
2) musical_instrument-14-1
3) musical_instrument-14-3

@kocio-pl
Copy link
Collaborator Author

Another take:
4) musical_instrument-14-5
5) musical_instrument-14-6

@kocio-pl
Copy link
Collaborator Author

Hm, maybe saxophone would do...

@nebulon42 Do you have any ideas or actual drafts for this shop type?

@matkoniecz
Copy link
Contributor

  1. is the best from proposed ones

@nebulon42
Copy link
Contributor

I have no special ideas. I think any musical instrument could work. 2 or 3 maybe, with some tweaking.

@daganzdaanda
Copy link

A trumpet is a good symbol, I think. Number 3) has no piston valves in the middle, maybe they could be added to reduce the "hole".

@kocio-pl
Copy link
Collaborator Author

So the popular opinion is clear - I will try to work with the trumpet.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 4, 2015

All about details, which are visible mostly at higher resolutions, and slightly better with current icon size:
7) musical_instrument-14-24

@matkoniecz
Copy link
Contributor

I think that 3) is still the best (7 started to look like scheme of electronics, with diode on the left and resistor on the bottom).

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 4, 2015

Maybe I have tried too hard to make everything visible (piston valves left untouched):
8) musical_instrument-14-25
9) musical_instrument-14-26

@matkoniecz
Copy link
Contributor

to keep also 3) easy to compare:

  1. musical_instrument-14-3
  2. musical_instrument-14-25
  3. musical_instrument-14-26

@matkoniecz
Copy link
Contributor

  1. and 9) are the best.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 5, 2015

What about piston valves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants