-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special rendering for shop=musical_instrument #1420
Comments
This icon is already in use for |
I think it could be more specific - like guitar or piano. But wasn't it disco ball that we were trying to apply here or was it some other tag? |
My proposition: |
I know what it's supposed to be, but I'm concerned it could be confused with other things (shoe, ice skate, cleats, etc.). Can you maybe try a guitar? |
Hm, maybe saxophone would do... @nebulon42 Do you have any ideas or actual drafts for this shop type? |
|
I have no special ideas. I think any musical instrument could work. 2 or 3 maybe, with some tweaking. |
A trumpet is a good symbol, I think. Number 3) has no piston valves in the middle, maybe they could be added to reduce the "hole". |
So the popular opinion is clear - I will try to work with the trumpet. |
I think that 3) is still the best (7 started to look like scheme of electronics, with diode on the left and resistor on the bottom). |
|
What about piston valves? |
We should start rendering shop=musical_instrument, probably with this icon from osmfr-cartocss fork:
https://github.com/cquest/osmfr-cartocss/blob/master/symbols/musical_instrument.svg
[It was proposed in meta-issue #1402]
The text was updated successfully, but these errors were encountered: