Adding shop=musical_instrument icon #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #1420 I prefer version 3 for icon (but here it seems that difference is smaller than from my impression there - as result of colour change). |
|
7, 8 and 9 comparative field test (3 was too rough in SVG): I would choose 8. |
|
I think that 9 is slightly better. |
|
I just forgot to change the code because I didn't expect @math1985 will be so quick in this case, but when I look at it now, I still think 7 was the best (with 9 being the worst) and nobody else complained, so I'm happy with the outcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1420.