Tagcloud handle test failure #9252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not hardcode css-snippet
Reintroduce parameter in test cleanup cruft
Displaying console logs in UTC
Remove unused imports
Save settings on enter keypress
remove watermark from timelion
…l-order Ensure dashboard panels appear in the correct order
Flag scripted fields as searchable and aggregatable
Explicitly ignore plugin directories
[docs] Init breaking changes
Support decimals in histogram interval
…cess. The goal is to clarify where URL state is coming from, when working with visualizations. Some of the classes touched upon are: SavedVis, PersistedState, AppState, and base classes. Explored files: - src/core_plugins/kibana/public/visualize/editor/editor.js - src/core_plugins/kibana/public/visualize/saved_visualizations/_saved_vis.js - src/ui/public/courier/data_source/_doc_send_to_es.js - src/ui/public/courier/data_source/doc_source.js - src/ui/public/courier/saved_object/saved_object.js - src/ui/public/es.js - src/ui/public/events.js - src/ui/public/persisted_state/persisted_state.js - src/ui/public/state_management/app_state.js - src/ui/public/state_management/state.js - src/ui/public/vis/agg_config.js - src/ui/public/vis/agg_configs.js - src/ui/public/vis/vis.js
…rl-state-files Add comments and inline docs for visualization saving and editing process.
…e. Apply to Management landing page.
…erview-styles Add classes for standardizing the vertical rhythm of content on a page.
Console now autocompletes indexes
Now that we support Painless scripted fields users can create scripted date fields, and thus scripted date histograms. The label making method for the date histogram agg was getting the field name in a way that was incompatible with scripted fields, so I've added some fallback code for that scenario. I looked through the rest of the makeLabel methods on all the other aggs and they all correctly access the field displayName already so this should only need fixed for date histograms. Fixes elastic#8632
Fix label on scripted field date histograms
Bump node version to 6.7.0
Now that we support Painless scripted fields users can create scripted date fields, and thus scripted date histograms. The label making method for the date histogram agg was getting the field name in a way that was incompatible with scripted fields, so I've added some fallback code for that scenario. I looked through the rest of the makeLabel methods on all the other aggs and they all correctly access the field displayName already so this should only need fixed for date histograms. Now with more lodash for safer access Fixes elastic#8632
…ic#8914) * visualizations emit 'renderComplete' event when done rendering (elastic#8914)
Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See elastic#9024 Related elastic/elasticsearch#21479
* Add original message back to loading screen. Run CSS through autoprefixer. * Make kibanaWelcomeView and kibanaWelcomeLogo styles available to plugins which may need them, by moving them into ui_app.jade.
… instructions (made redundant by elastic.co getting started guide). (elastic#9104)
) * [uiExports] add replaceInjectedVars() export type * [ui] do not assume es plugin is always there * [server/status] fix typo * [ui] add errror handling to /app/{id} endpoint * [ui] add tests for replaceInjectedVars() * [npm] swap out jsdom with cheerio * [server/ui] continue extender => replacer rename
* support scripted fields * update column_chart test to check brush for ordered data * brush histogram * incorporate changes request by cjcenizal * fixed typo * support scripted fields * update column_chart test to check brush for ordered data * Fix init_x_axis unit tests. * add brush_event test * Fix small timezone bug in brushEvent tests. Polish test descriptions.
…-test-subj selectors for menu items. (elastic#9133) * Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items. * Run checkPlugins task as part of test:ui:runner task.
Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper.
A tag cloud visualization is a visual representation of text data, typically used to visualize free form text. Tags are usually single words. The font size of word corresponds with its importance.
* correctly use implementsRenderComplete from vis config * set implementsRenderComplete on all vis types * emit on DOM instead of the vis * vis doesn't need to be an EventEmitter * listen for renderComplete on visualize set and update element attributes as the event(s) fire, and indicate if they ever will * [vislib/handler] fall through to lower return * [vislibRenderbot/tests] reduce expected call count * [vis/tests] add $element to test injectors * [markdownVis] fix test
…lastic#9181) * Do not crash for warning and error nodes without http published address * [es version check] Prevent failure on incompatible nodes without http
* [docTable/row] delay first render until watchers initialize * [docTable/row] emit a renderComplete event, count in table directive * [renderCounter] unify render counting login into directive * [docTable] remove unused var
* [server/uiSettings+shortUrl] surface errors from es * [uiExports/replaceInjectedVars] update the uiSettings stub * [uiSettings] correct test cases after moving from 401 -> 403
Note there is a bug that already exists in timeline where the notify.info message disappears immediately. Not fixing in this PR, but the delete info message suffers the same bug as the save info message does already.
…lastic#9127) * Create tests for savedobject.js in prep of refactoring and changes * Address code review comments * Remove needless injector param, replace with es
* fix issue with hiding loading message in embedded mode * Fix match as well This chunk of logic only matched on =embed, not =embed=true, which is what the url given by sharing uses.
* Fix filters for complex painless scripted fields Painless scripted fields that consisted of more than a single expression would break when the user attempted to filter on them in Discover or Visualize because of the naive way we were building them. We now wrap the user's script in a lambda so that it can be as complex at they need it to be. The only special exception is that the user cannot define named functions since those cannot go inside a Painless lambda. Fixes elastic#9024 Related elastic/elasticsearch#21635 * DRY it up * Phrase tests * Only include necessary comparators and add tests
* Improve robustness Tagcloud was subsceptible to race conditions, potentially yielding stale clouds. - Introduced queue to explicitly keep track of outstanding jobs and avoid clobbering of the state. - Expanded unit tests * ensure tagcloud expands to full height in reporting * remove magic numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the same as #9251.
There are intermittent failures on various branches in CI. This is to try and see if we can coax a more meaningful error message
DO NOT MERGE! THIS IS TO RUN THIS CHANGE IN CI AGAINST 5.1