Add a method for plugins to add injected vars to every app #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
reviewed
Nov 16, 2016
| import KbnServer from '../../server/kbn_server'; | ||
|
|
||
| const getInjectedVarsFromResponse = (resp) => { | ||
| const document = jsdom.jsdom(resp.payload); |
There was a problem hiding this comment.
Can't you just use jquery to do the css selection and read the data from the DOM here? And if not, wouldn't something like cheerio be a lighter solution for it?
There was a problem hiding this comment.
These tests are run in node, so jQuery isn't an option. cheerio looks perfect
|
LGTM! |
elastic-jasper
added a commit
that referenced
this pull request
Nov 18, 2016
Backports PR #9071 **Commit 1:** [uiExports] add replaceInjectedVars() export type * Original sha: 7ad237c * Authored by spalger <[email protected]> on 2016-11-14T22:11:47Z **Commit 2:** [ui] do not assume es plugin is always there * Original sha: 5ac383d * Authored by spalger <[email protected]> on 2016-11-15T00:28:45Z **Commit 3:** [server/status] fix typo * Original sha: 3a97f69 * Authored by spalger <[email protected]> on 2016-11-15T00:29:19Z **Commit 4:** [ui] add errror handling to /app/{id} endpoint * Original sha: 33aa9de * Authored by spalger <[email protected]> on 2016-11-15T00:29:43Z **Commit 5:** [ui] add tests for replaceInjectedVars() * Original sha: 4471453 * Authored by spalger <[email protected]> on 2016-11-15T00:30:14Z **Commit 6:** Merge branch 'master' of github.com:elastic/kibana into implement/extend-injected-vars * Original sha: d316ff5 * Authored by spalger <[email protected]> on 2016-11-17T01:54:58Z **Commit 7:** [npm] swap out jsdom with cheerio * Original sha: c0e6a62 * Authored by spalger <[email protected]> on 2016-11-17T01:58:01Z **Commit 8:** [server/ui] continue extender => replacer rename * Original sha: 3d833e8 * Authored by spalger <[email protected]> on 2016-11-17T20:55:11Z
spalger
pushed a commit
that referenced
this pull request
Nov 18, 2016
Backports PR #9071 **Commit 1:** [uiExports] add replaceInjectedVars() export type * Original sha: 7ad237c * Authored by spalger <[email protected]> on 2016-11-14T22:11:47Z **Commit 2:** [ui] do not assume es plugin is always there * Original sha: 5ac383d * Authored by spalger <[email protected]> on 2016-11-15T00:28:45Z **Commit 3:** [server/status] fix typo * Original sha: 3a97f69 * Authored by spalger <[email protected]> on 2016-11-15T00:29:19Z **Commit 4:** [ui] add errror handling to /app/{id} endpoint * Original sha: 33aa9de * Authored by spalger <[email protected]> on 2016-11-15T00:29:43Z **Commit 5:** [ui] add tests for replaceInjectedVars() * Original sha: 4471453 * Authored by spalger <[email protected]> on 2016-11-15T00:30:14Z **Commit 6:** Merge branch 'master' of github.com:elastic/kibana into implement/extend-injected-vars * Original sha: d316ff5 * Authored by spalger <[email protected]> on 2016-11-17T01:54:58Z **Commit 7:** [npm] swap out jsdom with cheerio * Original sha: c0e6a62 * Authored by spalger <[email protected]> on 2016-11-17T01:58:01Z **Commit 8:** [server/ui] continue extender => replacer rename * Original sha: 3d833e8 * Authored by spalger <[email protected]> on 2016-11-17T20:55:11Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
) Backports PR elastic#9071 **Commit 1:** [uiExports] add replaceInjectedVars() export type * Original sha: 7ad237c * Authored by spalger <[email protected]> on 2016-11-14T22:11:47Z **Commit 2:** [ui] do not assume es plugin is always there * Original sha: 5ac383d * Authored by spalger <[email protected]> on 2016-11-15T00:28:45Z **Commit 3:** [server/status] fix typo * Original sha: 3a97f69 * Authored by spalger <[email protected]> on 2016-11-15T00:29:19Z **Commit 4:** [ui] add errror handling to /app/{id} endpoint * Original sha: 33aa9de * Authored by spalger <[email protected]> on 2016-11-15T00:29:43Z **Commit 5:** [ui] add tests for replaceInjectedVars() * Original sha: 4471453 * Authored by spalger <[email protected]> on 2016-11-15T00:30:14Z **Commit 6:** Merge branch 'master' of github.com:elastic/kibana into implement/extend-injected-vars * Original sha: d316ff5 * Authored by spalger <[email protected]> on 2016-11-17T01:54:58Z **Commit 7:** [npm] swap out jsdom with cheerio * Original sha: c0e6a62 * Authored by spalger <[email protected]> on 2016-11-17T01:58:01Z **Commit 8:** [server/ui] continue extender => replacer rename * Original sha: 3d833e8 * Authored by spalger <[email protected]> on 2016-11-17T20:55:11Z Former-commit-id: 2b04dde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several times while developing x-pack we have needed to little bits of data from the server at UI Bootstrap time. This can currently be solved by either putting a static set of variables in your
injectDefaultVars()ui-export, or make a request at bootstrap and delay everything for the request to complete.The later has become increasingly necessary, and has lead to several race-conditions as we try to expose a synchronous API for data that is loaded asynchronously (unless it's cached).
This change adds a
replaceInjectedVars(originalInjectedVars, request, server)uiExport type that receives theinjectedVarscreated by the app that is being rendered, the currentrequest, and thehapiserver object. The function should return newinjectedVars(or a promise for one) to be sent to the view in this render.@w33ble and @lukasolson worked with me on the design, so we could make sure that it made sense from a plugin authors perspective