Save settings on enter keypress #8571
Conversation
Remove unused imports
|
LGTM |
|
Looks like it'd also be possible to use this directive, https://code.angularjs.org/1.4.7/docs/api/ng/directive/ngKeypress, not sure if we have any 'standard' way to do this. My LGTM stands though :) |
| if (event.which === 13) { | ||
| self.apply(); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't know if there has been a style discussion or decision on arrow functions but if you use the arrow style I think you can get rid of the self variable (suggestion only and curious to hear if there is a reason not to use arrow style).
There was a problem hiding this comment.
I wanted a named reference to the function so I could unbind it. If I'd used arrow syntax, I would have to assign it to a variable, which to me defeats the point of using an anonymous function. Happy to change it though, no big preference either way.
There was a problem hiding this comment.
interesting, thanks for the explanation. I thought the main benefit of arrow functions was to avoid the binding or 'this' assignments, I didn't realize that people use it only for anonymous function situations. I took a look at the airbnb style guide (in case we make a decision to use that) and it looks like it suggests arrow fn or .bind, but favors those both over saving a 'this' reference. https://github.com/airbnb/javascript#naming--self-this
But since we haven't yet committed to using that style guide, so I'm good with it as is. :)
|
@kobelb I just could not get that ng-keypress directive to fire at all inside the settings directive. Maybe I overlooked something simple.. |
--------- **Commit 1:** Save settings on enter keypress Remove unused imports * Original sha: 09d3346 * Authored by Thomas Neirynck <[email protected]> on 2016-10-06T15:46:48Z
--------- **Commit 1:** Save settings on enter keypress Remove unused imports * Original sha: 09d3346 * Authored by Thomas Neirynck <[email protected]> on 2016-10-06T15:46:48Z
[backport] PR #8571 to 5.x
[backport] PR #8571 to 5.0
--------- **Commit 1:** Save settings on enter keypress Remove unused imports * Original sha: afd4b4171b0298311f3d3d2726604fefc259b4b4 [formerly 09d3346] * Authored by Thomas Neirynck <[email protected]> on 2016-10-06T15:46:48Z Former-commit-id: de05644
[backport] PR elastic#8571 to 5.x Former-commit-id: 395d086
Closes #8378. Save sense settings when pressing enter.
also removed some unused imports from Sense.