Add ability to delete timelion sheets #9191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note there is a bug that already exists in timeline where the notify.info message disappears immediately. Not fixing in this PR, but the delete info message suffers the same bug as the save info message does already.
|
Most straightforward way to address #9055 Note that the Graph UI also addresses deleting workspaces by a "Delete" button in the UI. Not consistent with Discover, Visualize, and Dashboard, but since we plan to rework how saved object management is going to be done more globally in the near future, this seems like a good compromise. |
|
LGTM |
thomasneirynck
approved these changes
Nov 23, 2016
elastic-jasper
added a commit
that referenced
this pull request
Nov 28, 2016
Backports PR #9191 **Commit 1:** Add ability to delete timeline sheets Note there is a bug that already exists in timeline where the notify.info message disappears immediately. Not fixing in this PR, but the delete info message suffers the same bug as the save info message does already. * Original sha: f53a1a8 * Authored by Stacey Gammon <[email protected]> on 2016-11-22T21:12:14Z
stacey-gammon
pushed a commit
that referenced
this pull request
Nov 28, 2016
Backports PR #9191 **Commit 1:** Add ability to delete timeline sheets Note there is a bug that already exists in timeline where the notify.info message disappears immediately. Not fixing in this PR, but the delete info message suffers the same bug as the save info message does already. * Original sha: f53a1a8 * Authored by Stacey Gammon <[email protected]> on 2016-11-22T21:12:14Z
tbragin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds delete ability to top nav.
Note there is a bug that already exists in timeline where the
notify.info message disappears immediately. Not fixing in this PR, just noting
the delete info message suffers the same bug as the save info message.