Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes for standardizing the vertical rhythm of content on a page. #8628

Merged

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Oct 11, 2016

And apply them to the Management landing page.

This is only a styles refactor, so there should be no noticeable differences to the user.

Before

image

After

image

@pickypg
Copy link
Member

pickypg commented Oct 11, 2016

Changes look fine to me. I left a comment that you can feel free to ignore.

@pickypg pickypg added the v5.1.0 label Oct 11, 2016
@cjcenizal cjcenizal removed the v5.0.1 label Oct 11, 2016
@cjcenizal cjcenizal merged commit d673a53 into elastic:master Oct 11, 2016
@cjcenizal cjcenizal deleted the improvement/product-overview-styles branch October 11, 2016 22:55
elastic-jasper added a commit that referenced this pull request Oct 11, 2016
---------

**Commit 1:**
Add classes for standardizing the vertical rhythm of content on a page. Apply to Management landing page.

* Original sha: 0eeb17c
* Authored by CJ Cenizal <[email protected]> on 2016-10-11T21:37:34Z
cjcenizal added a commit that referenced this pull request Oct 11, 2016
[backport] PR #8628 to 5.x - Add classes for standardizing the vertical rhythm of content on a page.
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
---------

**Commit 1:**
Add classes for standardizing the vertical rhythm of content on a page. Apply to Management landing page.

* Original sha: 6c3b32fff8fecf2e008b0eeea68bbc898e28a30c [formerly 0eeb17c]
* Authored by CJ Cenizal <[email protected]> on 2016-10-11T21:37:34Z


Former-commit-id: 24b4fff
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[backport] PR elastic#8628 to 5.x - Add classes for standardizing the vertical rhythm of content on a page.

Former-commit-id: 2780784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants