-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REVERTED in #9256 - [npm] install deps "global-style" #9136
Conversation
Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper.
Can you do a rough analysis on path lengths in Kibana right now with this enabled? |
Interestingly enough, it doesn't effect the longest path in the dependencies: 191 characters, and it's installed with the same path regardless of global-style
to find the longest path:
|
Also interesting, the same is true with |
If I install just production dependencies I get 126 in normal mode, and 130 in global-style mode # deduped tree 126
node_modules/@elastic/kibana-ui-framework/src/guide/views/local_nav/local_nav_menu_item_states/local_nav_menu_item_states.html
# global-style 130
node_modules/bunyan/node_modules/dtrace-provider/build/Release/.deps/Release/obj.target/DTraceProviderBindings/dtrace_provider.o.d So, it actually doesn't have much impact on the bottom line |
I can't think of any problems this would create, so I guess we should just see it in action. I do like the result of the change. LGTM @spalger Can you do the same change for x-pack as well? |
Backports PR #9136 **Commit 1:** [npm] install deps "global-sytle" Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper. * Original sha: 95103f0 * Authored by Spencer <[email protected]> on 2016-11-18T16:43:54Z * Committed by GitHub <[email protected]> on 2016-11-18T16:43:54Z
Backports PR #9136 **Commit 1:** [npm] install deps "global-sytle" Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper. * Original sha: 95103f0 * Authored by Spencer <[email protected]> on 2016-11-18T16:43:54Z * Committed by GitHub <[email protected]> on 2016-11-18T16:43:54Z
This change, which was originally introduced in elastic#9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides.
This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides.
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <[email protected]> on 2016-11-29T20:29:43Z
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <[email protected]> on 2016-11-29T20:29:43Z
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <[email protected]> on 2016-11-29T20:29:43Z
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <[email protected]> on 2016-11-29T20:29:43Z
Backports PR elastic#9136 **Commit 1:** [npm] install deps "global-sytle" Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper. * Original sha: 95103f0 * Authored by Spencer <[email protected]> on 2016-11-18T16:43:54Z * Committed by GitHub <[email protected]> on 2016-11-18T16:43:54Z Former-commit-id: 269ee06
Backports PR elastic#9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in elastic#9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <[email protected]> on 2016-11-29T20:29:43Z Former-commit-id: 9b43bdc
Installing dependencies "global-style" creates a top-level directory in
node_modules
for each direct dependency, and then creates a flat tree of dependencies inside each of those.I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in
node_modules
.Unfortunately the
node_modules
directory will be a little deeper.