Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripted date fields have undefined labels in charts #8632

Closed
thomasneirynck opened this issue Oct 11, 2016 · 5 comments · Fixed by #8638 or #8646
Closed

Scripted date fields have undefined labels in charts #8632

thomasneirynck opened this issue Oct 11, 2016 · 5 comments · Fixed by #8638 or #8646
Labels
bug Fixes for quality problems that affect the customer experience PR sent v5.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 11, 2016 •
edited
Loading

A scripted field (date type) has no label on the X-axis of the chart.

This seems only occur for X-axis labels in Date histograms, and not for the Y-axis.

image
@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience P3 v5.0.0 labels Oct 11, 2016
@thomasneirynck
Copy link
Contributor Author

tested this on latest 5 release.

@Bargs
Copy link
Contributor

Bargs commented Oct 11, 2016

@epixa should we try to slip this fix into 5.0?

@thomasneirynck thomasneirynck changed the title Scripted fields have undefined labels in charts Scripted date fields have undefined labels in charts Oct 11, 2016
@epixa
Copy link
Contributor

epixa commented Oct 11, 2016

@Bargs Blegh, gross. I think it would depend on the extent of the changes, but we should fix it one way or another anyway. Care to take a swing?

@Bargs
Copy link
Contributor

Bargs commented Oct 11, 2016

I'll take a look tomorrow morning

Bargs added a commit to Bargs/kibana that referenced this issue Oct 12, 2016
@Bargs
Fix label on scripted field date histograms
7359b45 
Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Fixes elastic#8632
@Bargs Bargs mentioned this issue Oct 12, 2016
Merged
@Bargs
Copy link
Contributor

Bargs commented Oct 12, 2016

From what I can tell, this only affects date histograms. PR pending

@Bargs Bargs added the PR sent label Oct 12, 2016
elastic-jasper added a commit that referenced this issue Oct 12, 2016
@elastic-jasper
Backport PR #8638
de68ed0 
---------

**Commit 1:**
Fix label on scripted field date histograms

Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Fixes #8632

* Original sha: 7359b45
* Authored by Matthew Bargar <[email protected]> on 2016-10-12T15:10:15Z
@elastic-jasper elastic-jasper mentioned this issue Oct 12, 2016
Merged
Bargs referenced this issue in Bargs/kibana Oct 12, 2016
@Bargs
Fix label on scripted field date histograms
fc635bc 
Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Now with more lodash for safer access

Fixes elastic#8632
@Bargs Bargs mentioned this issue Oct 12, 2016
Merged
elastic-jasper referenced this issue Oct 13, 2016
@elastic-jasper
Backport PR #8646
da8f2c3 
---------

**Commit 1:**
Fix label on scripted field date histograms

Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Now with more lodash for safer access

Fixes elastic#8632

* Original sha: fc635bc
* Authored by Matthew Bargar <[email protected]> on 2016-10-12T22:30:15Z
elastic-jasper referenced this issue Oct 13, 2016
@elastic-jasper
Backport PR #8646
75096aa 
---------

**Commit 1:**
Fix label on scripted field date histograms

Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Now with more lodash for safer access

Fixes elastic#8632

* Original sha: fc635bc
* Authored by Matthew Bargar <[email protected]> on 2016-10-12T22:30:15Z
This was referenced Oct 13, 2016
Merged
Merged
Bargs referenced this issue Oct 13, 2016
@Bargs
Backport PR #8646
13ee3da 
---------

**Commit 1:**
Fix label on scripted field date histograms

Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Now with more lodash for safer access

Fixes elastic#8632

* Original sha: fc635bc
* Authored by Matthew Bargar <[email protected]> on 2016-10-12T22:30:15Z
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
@elastic-jasper
Backport PR elastic#8638
f6edcaf 
---------

**Commit 1:**
Fix label on scripted field date histograms

Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Fixes elastic#8632

* Original sha: 9bed93b73c0f3cc90dc1fa2889aa6b18acab402b [formerly 7359b45]
* Authored by Matthew Bargar <[email protected]> on 2016-10-12T15:10:15Z


Former-commit-id: de68ed0
airow referenced this issue in airow/kibana Feb 16, 2017
@elastic-jasper
Backport PR elastic#8646
4da5369 
---------

**Commit 1:**
Fix label on scripted field date histograms

Now that we support Painless scripted fields users can create scripted
date fields, and thus scripted date histograms. The label making method
for the date histogram agg was getting the field name in a way that was
incompatible with scripted fields, so I've added some fallback code for
that scenario. I looked through the rest of the makeLabel methods on all
the other aggs and they all correctly access the field displayName
already so this should only need fixed for date histograms.

Now with more lodash for safer access

Fixes elastic#8632

* Original sha: 613905da363b03c570a016db662bea28d26b6dad [formerly fc635bc]
* Authored by Matthew Bargar <[email protected]> on 2016-10-12T22:30:15Z


Former-commit-id: da8f2c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience PR sent v5.0.0
Projects
None yet
Milestone
No milestone
3 participants
@epixa @thomasneirynck @Bargs