Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items. #9133

Merged

Conversation

cjcenizal
Copy link
Contributor

No description provided.

@LeeDr
Copy link

LeeDr commented Nov 18, 2016

LGTM

@tbragin tbragin added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Nov 19, 2016
@cjcenizal
Copy link
Contributor Author

Functional tests pass locally.

@cjcenizal cjcenizal merged commit f0a8887 into elastic:master Nov 19, 2016
@cjcenizal cjcenizal deleted the improvement/menu-item-test-subj-selectors branch November 19, 2016 18:08
@cjcenizal cjcenizal added Team:QA Team label for QA Team v5.1.0 v6.0.0 labels Nov 19, 2016
elastic-jasper added a commit that referenced this pull request Nov 19, 2016
…-test-subj selectors for menu items.

Backports PR #9133

**Commit 1:**
Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items.

* Original sha: 84cf9ba
* Authored by CJ Cenizal <[email protected]> on 2016-11-17T21:28:09Z

**Commit 2:**
Run checkPlugins task as part of test:ui:runner task.

* Original sha: 7cdf829
* Authored by CJ Cenizal <[email protected]> on 2016-11-19T18:07:47Z
cjcenizal pushed a commit that referenced this pull request Nov 19, 2016
…-test-subj selectors for menu items. (#9155)

Backports PR #9133

**Commit 1:**
Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items.

* Original sha: 84cf9ba
* Authored by CJ Cenizal <[email protected]> on 2016-11-17T21:28:09Z

**Commit 2:**
Run checkPlugins task as part of test:ui:runner task.

* Original sha: 7cdf829
* Authored by CJ Cenizal <[email protected]> on 2016-11-19T18:07:47Z
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
…-test-subj selectors for menu items. (elastic#9155)

Backports PR elastic#9133

**Commit 1:**
Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items.

* Original sha: 84cf9ba
* Authored by CJ Cenizal <[email protected]> on 2016-11-17T21:28:09Z

**Commit 2:**
Run checkPlugins task as part of test:ui:runner task.

* Original sha: 7cdf829
* Authored by CJ Cenizal <[email protected]> on 2016-11-19T18:07:47Z

Former-commit-id: 1150ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:QA Team label for QA Team v5.1.1 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants