-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizations without spy panels causing error messages #9115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbragin
added
the
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
label
Nov 18, 2016
thomasneirynck
approved these changes
Nov 18, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Peter.
LGTM
Sorry for the delay on my end. Everything seems to be working as expected, but the error is gone here. LGTM! |
elastic-jasper
added a commit
that referenced
this pull request
Nov 21, 2016
Backports PR #9115 **Commit 1:** fixing error when vis has no spy panel * Original sha: c47f849 * Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
This was referenced Nov 21, 2016
ppisljar
pushed a commit
that referenced
this pull request
Nov 21, 2016
Backports PR #9115 **Commit 1:** fixing error when vis has no spy panel * Original sha: c47f849 * Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
ppisljar
added a commit
that referenced
this pull request
Nov 21, 2016
Backports PR #9115 **Commit 1:** fixing error when vis has no spy panel * Original sha: c47f849 * Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
ppisljar
pushed a commit
that referenced
this pull request
Nov 21, 2016
Backports PR #9115 **Commit 1:** fixing error when vis has no spy panel * Original sha: c47f849 * Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9115 **Commit 1:** fixing error when vis has no spy panel * Original sha: c47f849 * Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z Former-commit-id: 567d636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
review
v5.0.2
v5.1.1
v6.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visualizations without spy panels causing error messages
Fixes #9102
Visualize is trying to adjust the view of vis spy panel, but Timelion doesn't have a spy.
UPDATE: This error happens on Dashboard as well.
UPDATE2: This actually happens with any visualization that doesn't have a spy panel, which includes the Markdown panel.