Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizations without spy panels causing error messages #9115

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

ppisljar
Copy link
Member

Visualizations without spy panels causing error messages

Fixes #9102

Visualize is trying to adjust the view of vis spy panel, but Timelion doesn't have a spy.

UPDATE: This error happens on Dashboard as well.

UPDATE2: This actually happens with any visualization that doesn't have a spy panel, which includes the Markdown panel.

2c739804-abe9-11e6-9753-26aa178421d2

@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 18, 2016
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Peter.

LGTM

@w33ble
Copy link
Contributor

w33ble commented Nov 21, 2016

Sorry for the delay on my end. Everything seems to be working as expected, but the error is gone here. LGTM!

@ppisljar ppisljar merged commit 5ef7a52 into elastic:master Nov 21, 2016
elastic-jasper added a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
ppisljar pushed a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
ppisljar added a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
ppisljar pushed a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Backports PR elastic#9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <[email protected]> on 2016-11-17T11:39:29Z

Former-commit-id: 567d636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.0.2 v5.1.1 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants