Add a note on multi-statement scripted field limitation #9090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See elastic#9024 Related elastic/elasticsearch#21479
|
To avoid having info/warning boxes stacked three high I tried to incorporate the warning into the existing help text. I also didn't implement any logic to show/hide it based on the selected lang since we're already showing Painless and lucene info side by side there. |
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #9090 **Commit 1:** Add a note on multi-statement scripted field limitation Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See #9024 Related elastic/elasticsearch#21479 * Original sha: b4aaed8 * Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #9090 **Commit 1:** Add a note on multi-statement scripted field limitation Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See #9024 Related elastic/elasticsearch#21479 * Original sha: b4aaed8 * Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
epixa
pushed a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #9090 **Commit 1:** Add a note on multi-statement scripted field limitation Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See #9024 Related elastic/elasticsearch#21479 * Original sha: b4aaed8 * Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
epixa
pushed a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #9090 **Commit 1:** Add a note on multi-statement scripted field limitation Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See #9024 Related elastic/elasticsearch#21479 * Original sha: b4aaed8 * Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z
|
@epixa I thought we were waiting to merge this until we were sure we didn't have a better fix? Were you just wanting to make sure it got in 5.0.2? |
|
@Bargs I'd rather err on the side of getting it in so it goes out with 5.0.2. We can always revert it if we can fix the core issue before 5.0.2. |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9090 **Commit 1:** Add a note on multi-statement scripted field limitation Multi-statement scripts are currently incompatible with the way we create filters on scripted fields. We're investigating the possibility of enhancing elasticsearch to fix this issue, but we may have to fallback on showing users a warning if we can't reach an agreement in the near term. See elastic#9024 Related elastic/elasticsearch#21479 * Original sha: b4aaed8 * Authored by Matthew Bargar <[email protected]> on 2016-11-15T22:47:26Z Former-commit-id: 24840a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.
See #9024
Related elastic/elasticsearch#21479