Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI flake: Podman run/create two containers with the same IP #7096

Closed
edsantiago opened this issue Jul 27, 2020 · 16 comments
Closed

CI flake: Podman run/create two containers with the same IP #7096

edsantiago opened this issue Jul 27, 2020 · 16 comments
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. kind/test-flake Categorizes issue or PR as related to test flakes. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@edsantiago
Copy link
Member

Although it's not a frequent flake, it's still a flake, and should be fixed:

Podman run with --ip flag [It] Podman run two containers with the same IP

Podman create with --ip flag [It] Podman create two containers with the same IP

I tried to fix this some months ago in #5286 but obviously there's still something I missed.
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Aug 27, 2020

Sadly this is still active.

@edsantiago
Copy link
Member Author

Correct. Instances since initial filing:

None of these flaked three times, so they shouldn't've triggered an actual CI run failure, but some day it will again.

@edsantiago edsantiago added flakes Flakes from Continuous Integration and removed stale-issue labels Aug 27, 2020
@edsantiago edsantiago mentioned this issue Sep 22, 2020
Merged
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

@rhatdan rhatdan added kind/bug Categorizes issue or PR as related to a bug. kind/test-flake Categorizes issue or PR as related to test flakes. and removed stale-issue labels Oct 7, 2020
@github-actions
Copy link

github-actions bot commented Nov 8, 2020

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

cirrus-flake-summarize reports no incidents since 09-28, which is right around the time that @Luap99 merged #7835 so maybe this is fixed?

@rhatdan
Copy link
Member

rhatdan commented Nov 10, 2020

Maybe is good enough for me. We will reopen if it happens again.

@rhatdan rhatdan closed this as completed Nov 10, 2020
@edsantiago
Copy link
Member Author

It's back. Reopening.

Podman run with --ip flag [It] Podman run two containers with the same IP

@edsantiago edsantiago reopened this Mar 24, 2021
@edsantiago
Copy link
Member Author

another one

@edsantiago
Copy link
Member Author

Another one. podman (non-remote) fedora-33 root

@github-actions
Copy link

github-actions bot commented May 1, 2021

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

Sigh. Last seen on April 6; I guess that means I close it and reopen it when it happens again.

@edsantiago
Copy link
Member Author

edsantiago commented Jul 21, 2021 •
edited
Loading

Another one. This still is not fixed:

Podman run with --ip flag [It] Podman run two containers with the same IP

Leaving the issue closed because I know nobody is going to look into it, so I'm saving future-me the time it takes, 30 days hence, to context-switch back into this and sigh and close it.

UPDATE: the above failures are in the run test; this same CI run, on the same PR, also failed in the create test, but only once, not three times:

Podman create with --ip flag [It] Podman create two containers with the same IP

@edsantiago
Copy link
Member Author

And again, a triple failure causing a CI failure, but it's in f33 on an old branch so I'm not bothering to reopen.

@edsantiago
Copy link
Member Author

This just popped up again after many months of absence; but it's in test runs also affected by #14331 (the horrible sctp one)

Podman create with --ip flag [It] Podman create two containers with the same IP

Podman run with --ip flag [It] Podman run two containers with the same IP

@edsantiago edsantiago mentioned this issue Apr 24, 2023
Merged
edsantiago added a commit to edsantiago/libpod that referenced this issue Apr 24, 2023
@edsantiago
e2e create same-IP: try to fix flake
ae5ed6d 
Our friend containers#7096 is still not fixed: it continues to flake,
singletons only, and only in the "create" test (not "run").

My guess: maybe there's a race somewhere in IP assignment,
such that container1 can have an IP, but not yet be running,
and a container2 can sneak in and start with that IP, and
container1 is the one that fails?

Solution: tighten the logic so we wait for container1 to
truly be running before we start container2. And, when we
start container2, do so with -a so we get to see stdout.
(Am not expecting it to be helpful, but who knows).

Also very minor cleanup

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this issue May 1, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. kind/test-flake Categorizes issue or PR as related to test flakes. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edsantiago @rhatdan