Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix pin with make nixpkgs #9154

Merged

Conversation

hswong3i
Copy link
Collaborator

No description provided.

@vrothberg
Copy link
Member

The CI is enforcing changes to tests for commits. Can you add [NO TESTS NEEDED] to the body of your commit message and repush?

@edsantiago, nix/* may be a candidate for the positive list.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2021

LGTM
Once you sign your PR.
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hswong3i, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@edsantiago
Copy link
Member

@hswong3i instead of adding NO TESTS NEEDED, I think we're all totally fine if you include this as part of your PR:

diff --git a/contrib/cirrus/pr-should-include-tests b/contrib/cirrus/pr-should-include-tests
index caf27cf83..a3b4847a7 100755
--- a/contrib/cirrus/pr-should-include-tests
+++ b/contrib/cirrus/pr-should-include-tests
@@ -39,6 +39,7 @@ filtered_changes=$(git diff --name-status $base $head |
                        egrep -v  '^contrib/'          |
                        egrep -v  '^docs/'             |
                        egrep -v  '^hack/'             |
+                       egrep -v  '^nix/'              |
                        egrep -v  '^vendor/'           |
                        egrep -v  '^version/')
 if [[ -z "$filtered_changes" ]]; then

@cevich
Copy link
Member

cevich commented Feb 2, 2021

nix/* may be a candidate for the positive list.

Hrmmm...I swore I added that already in one of my PRs....yep, it's already there. Probably just need to rebase this PR.

Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i
Copy link
Collaborator Author

hswong3i commented Feb 3, 2021

nix/* may be a candidate for the positive list.

Hrmmm...I swore I added that already in one of my PRs....yep, it's already there. Probably just need to rebase this PR.

rebased ;-)

@rhatdan
Copy link
Member

rhatdan commented Feb 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit d178ba1 into containers:master Feb 4, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants