-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nix pin with make nixpkgs
#9154
Update nix pin with make nixpkgs
#9154
Conversation
69ff01a
to
f26b53f
Compare
The CI is enforcing changes to tests for commits. Can you add @edsantiago, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hswong3i, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hswong3i instead of adding diff --git a/contrib/cirrus/pr-should-include-tests b/contrib/cirrus/pr-should-include-tests
index caf27cf83..a3b4847a7 100755
--- a/contrib/cirrus/pr-should-include-tests
+++ b/contrib/cirrus/pr-should-include-tests
@@ -39,6 +39,7 @@ filtered_changes=$(git diff --name-status $base $head |
egrep -v '^contrib/' |
egrep -v '^docs/' |
egrep -v '^hack/' |
+ egrep -v '^nix/' |
egrep -v '^vendor/' |
egrep -v '^version/')
if [[ -z "$filtered_changes" ]]; then |
Hrmmm...I swore I added that already in one of my PRs....yep, it's already there. Probably just need to rebase this PR. |
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
f26b53f
to
bda95bd
Compare
rebased ;-) |
/lgtm |
No description provided.