[NO TESTS NEEDED] swagger: add missing schema properties

[tmds]

@jwhonce ptal.

[tmds]

cc @baude

[zhangguanzhang]

thanks for contribute, and your commit messages should change to include Sign-off-by $name .. and git push -f

[zhangguanzhang]

Fixes: #8577

[rhatdan]

Do we need this change in all of the register_*go files?

[tmds]

Do we need this change in all of the register_*go files?

@rhatdan I think this covers all needed cases. Do you have some specific section in mind that still should be patched?

Is this good to merge?

[rhatdan]

Could you repush to see if we get by the smoke test.

[baude]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, tmds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

I think thew NO_TESTS_NEEDED needs to be in the body of your commit message. Speaking of which, can you provide a commit message?

[baude]

LGTM other than my comments about commit messages

[jwhonce]

@tmds Please let me know what tool you are using, or why you need these changes? I'm curious if we need to add that property to all our responses.

[tmds]

Please let me know what tool you are using, or why you need these changes?

I'm using a .NET specific tool: https://github.com/RicoSuter/NSwag

Without the schema properties it considers the swagger invalid.
I'm not a swagger expert. Based on the docker swagger, and skimming through the swagger spec, I think the tool is probably right.

I'm curious if we need to add that property to all our responses.

The other responses already include it, for example:

  BadParamError:
    description: Bad parameter in request
    schema:
      properties:
        cause:
          description: API root cause formatted for automated parsing
          example: API root cause
          type: string
          x-go-name: Because
        message:
          description: human error message, formatted for a human to read
          example: human error message
          type: string
          x-go-name: Message
        response:
          description: http response code
          format: int64
          type: integer
          x-go-name: ResponseCode
      type: object

[tmds]

Is this good to merge?

[mheon]

/lgtm

[mheon]

Wait, CI is red
/hold

[mheon]

@tmds I think you need a force-push to make the [NO TESTS NEEDED] label work - I recommend changing something trivial (punctuation in a description, maybe) and force-pushing an amended commit

[TomSweeneyRedHat]

LGTM
assuming happy tests

[rhatdan]

@tmds Could you rebase your PR and repush, so that the tests will notice the [NO TESTS NEEDED] flag and we can get this in.

[tmds]

I've rebased.

[mheon]

/lgtm
/hold cancel