[BZ #2083997] pod: build pause image in custom user NS

[vrothberg]

Use the host UID and host GID mapping when building the local pause
image for a Pod with a custom mapping. Otherwise, the mappings are off
and the build fails. Propagating the mapping to the build container is
not needed since the pause image ships merely a copied catatonit from
the host.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2083997
Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

Fix a bug where the pause image of a Pod with a custom ID mapping could not be built (https://bugzilla.redhat.com/show_bug.cgi?id=2083997).

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

@giuseppe @rhatdan @TomSweeneyRedHat PTAL

@mheon FYI, probably a backport candidate for v4.1. Probably v4.0 (RHEL) if the council wishes.

[mheon]

LGTM, but your tests are red

[vrothberg]

@rhatdan @TomSweeneyRedHat PTAL

[rhatdan]

/lgtm
/hold

[vrothberg]

/hold cancel

[vrothberg]

/cherry-pick v4.1

[openshift-cherrypick-robot]

@vrothberg: once the present PR merges, I will cherry-pick it on top of v4.1 in a new PR and assign it to you.

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@vrothberg: #14232 failed to apply on top of branch "v4.1":

Applying: pod: build pause image in custom user NS
Using index info to reconstruct a base tree...
A	pkg/specgen/generate/pause_image.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/specgen/generate/pause_image.go deleted in HEAD and modified in pod: build pause image in custom user NS. Version pod: build pause image in custom user NS of pkg/specgen/generate/pause_image.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 pod: build pause image in custom user NS
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.