Support annotations from containers.conf #9284
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
This is important for a blog I am writing on sharing supplemental groups into a container. |
pkg/specgen/generate/container.go
Outdated
| k := split[0] | ||
| v := "" | ||
| if len(split) == 2 { | ||
| v = split[0] |
There was a problem hiding this comment.
| v = split[0] | |
| v = split[1] |
wrong index
|
Needs fix from @Luap99 then LGTM. Concerned as to why tests are green despite the logic error. |
|
The =1 is not important to crun, if crun sees the value, it will allow the supplemental groups in. |
|
But this isn't the only important annotation that exists, and the test did not catch that the code was incorrect |
|
Good point now, the test looks for the value 1. |
|
I also added another PR here to fix a race condition in #9286. |
|
LGTM once things go green |
Currently podman does not use the annotations specified in the containers.conf. This PR fixes this. Signed-off-by: Daniel J Walsh <[email protected]>
Service needs to be restarted in order to read the CONTAINERS_CONF file. Not resetting this can lead to lots of flakes, since the test will use whatever the host system has to be set in it's containers.conf. Fixes: containers#9286 Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM |
github-actions
bot
added
the
locked - please file new issue/PR
Currently podman does not use the annotations specified in the
containers.conf. This PR fixes this.
Signed-off-by: Daniel J Walsh [email protected]