Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configuration for rootless podman #7079

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 24, 2020

I updated the configuration part of the tutorial on rootless podman. I added the
order in which configuration files are read in and a hint, how users can create
default configuration in the home directories.

Closes #6777

Signed-off-by: Niklas Netter [email protected]
Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Jul 24, 2020

Replaces #6954

@@ -1,4 +1,4 @@
![PODMAN logo](../../logo/podman-logo-source.svg)
g![PODMAN logo](../../logo/podman-logo-source.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g at the start looks like an emacs remnant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@TomSweeneyRedHat
Copy link
Member

One nit to fix, otherwise LGTM

@rhatdan rhatdan force-pushed the tuturial branch 4 times, most recently from faa446a to 0c5204a Compare July 25, 2020 09:37
I updated the configuration part of the tutorial on rootless podman. I added the
 order in which configuration files are read in and a hint, how users can create
 default configuration in the home directories.

Closes containers#6777

Signed-off-by: Niklas Netter <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
@giuseppe
Copy link
Member

/lgtm

@mheon mheon added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 14f8085 into containers:master Jul 28, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rootless config files are not created
7 participants