Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --format to pod inspect #6372

Merged
merged 1 commit into from
May 27, 2020
Merged

Add --format to pod inspect #6372

merged 1 commit into from
May 27, 2020

Conversation

boaz0
Copy link
Collaborator

@boaz0 boaz0 commented May 24, 2020

closes #6283

@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2020
@rhatdan
Copy link
Member

rhatdan commented May 24, 2020

Could you add some tests and a couple of examples in the man page.
Maybe an example in podman pod inspect --help
Also need changes to command completions.

@boaz0
Copy link
Collaborator Author

boaz0 commented May 24, 2020

Sure @rhatdan !

@boaz0 boaz0 marked this pull request as ready for review May 25, 2020 08:18
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2020
@boaz0
Copy link
Collaborator Author

boaz0 commented May 25, 2020

Ready for review
@rhatdan @vrothberg

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 26, 2020
@rhatdan
Copy link
Member

rhatdan commented May 26, 2020

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: boaz0, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@rhatdan
Copy link
Member

rhatdan commented May 26, 2020

@giuseppe @mheon @TomSweeneyRedHat @baude @QiWang19 @jwhonce @vrothberg PTAL

QiWang19
QiWang19 reviewed May 26, 2020
View reviewed changes
completions/bash/podman Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

One underline nit, LGTM once fixed.

@boaz0
Add --format to pod inspect
1f8a787 
Signed-off-by: Boaz Shuster <[email protected]>
@QiWang19
Copy link
Contributor

LGTM

@mheon
Copy link
Member

mheon commented May 27, 2020

/lgtm
/hold

Looks like one test flaked, we can merge once it's green

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@edsantiago
Copy link
Member

cirrus-flake-summarize blames the json-output flake which should soon be fixed by #6406

test fedora-31 fedora-31

2020-05-27T01:27:35 integration_test

@rhatdan
Copy link
Member

rhatdan commented May 27, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 89b4683 into containers:master May 27, 2020
@boaz0
Copy link
Collaborator Author

boaz0 commented May 27, 2020

Sweet! Thanks you @rhatdan @mheon @edsantiago @TomSweeneyRedHat @QiWang19 @vrothberg

@boaz0 boaz0 deleted the gh_6283 branch May 27, 2020 14:23
@edsantiago edsantiago mentioned this pull request Jul 27, 2020
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@QiWang19 QiWang19 QiWang19 left review comments

@vrothberg vrothberg vrothberg left review comments

@edsantiago edsantiago edsantiago left review comments

@baude baude Awaiting requested review from baude

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman pod inspect: needs --format option
9 participants
@boaz0 @openshift-ci-robot @rhatdan @TomSweeneyRedHat @QiWang19 @mheon @edsantiago @vrothberg @openshift-merge-robot