Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat networks endpoint for a empty result #9295

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Feb 9, 2021

The networks list compat api endpoint must return []
and not null if no networks are found.

Fixes #9293

The networks list compat api endpoint must return `[]`
and not `null` if no networks are found.

Fixes containers#9293

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@rhatdan
Copy link
Member

rhatdan commented Feb 9, 2021

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
but would like a head nod from @baude or @jwhonce

@baude
Copy link
Member

baude commented Feb 9, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
@baude
Copy link
Member

baude commented Feb 9, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@mheon
Copy link
Member

mheon commented Feb 9, 2021

Restarted one test, looked like a flake.

@rhatdan
Copy link
Member

rhatdan commented Feb 10, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2021
@mheon
Copy link
Member

mheon commented Feb 10, 2021

/hold

Failing test

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2021
@mheon
Copy link
Member

mheon commented Feb 10, 2021

It's a different one this time - another flake?

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@vrothberg
Copy link
Member

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 055e2dd into containers:master Feb 10, 2021
@Luap99 Luap99 deleted the fix-9293 branch February 10, 2021 10:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APIv2] /networks endpoint returns null instead of [] when there're no networks
8 participants