Copy the content from the underlying image into the newly created volume

[vikas-goel]

Fixes: #10262

Signed-off-by: Vikas Goel [email protected]

[vikas-goel]

@mheon , @rhatdan , @Luap99 , @TomSweeneyRedHat ,
I am facing two issues, one related to test case and another about the code change. I am posting them separately. I will appreciate any guidance.

[vikas-goel]

I am using config/containers-volume.conf in test case but the execution failing to find the file. I have tried creating the file runtime in tmp directory instead of static file, that doesn't help either.

[+0935s] Running: /var/tmp/go/src/github.com/containers/podman/bin/podman --storage-opt vfs.imagestore=/tmp/podman/imagecachedir --root /tmp/podman_test791424325/crio --runroot /tmp/podman_test791424325/crio-run --runtime crun --conmon /usr/bin/conmon --cni-config-dir /etc/cni/net.d --cgroup-manager cgroupfs --tmpdir /tmp/podman_test791424325 --events-backend file --storage-driver vfs create --name ctr-copy dataimg
[+0935s] time="2021-07-19T15:47:35Z" level=error msg="Error streaming contents of container c15a6d0d258da0180568a3a4a502dc19e9c9a8984b48bedeb52d292e1cfa3608 directory for volume copy-up: error in copier subprocess: time=\"2021-07-19T15:47:35Z\" level=error msg=\"finding config on system: CONTAINERS_CONF file: stat config/containers-volume.conf: no such file or directory\"\n"
[+0935s] Error: error copying up to volume d2e89f0d1df08c3999078ff13be71a999bf6d507468b348956ebe0ce360e9f71: error in copier subprocess: time="2021-07-19T15:47:35Z" level=error msg="finding config on system: CONTAINERS_CONF file: stat config/containers-volume.conf: no such file or directory"

[vikas-goel]

I am facing an issue where removing the container and volume created using prepare_volume_on_create = true show the following error message. Both the container and volume get removed, though.

# ~/go/src/github.com/containers/podman/bin/podman rm -afv
Error: error removing container 58865407f8f7c1858704375a173a1cc93da4280cdb079aad44be536069540eff root filesystem: 2 errors occurred:
        * unlinkat /var/lib/containers/storage/overlay-containers/58865407f8f7c1858704375a173a1cc93da4280cdb079aad44be536069540eff/userdata/shm: device or resource busy
        * unlinkat /var/lib/containers/storage/overlay-containers/58865407f8f7c1858704375a173a1cc93da4280cdb079aad44be536069540eff/userdata/shm: device or resource busy

If I run container init and container cleanup after creating the container with prepare_volume_on_create = true option, then the error does not happen.

[mheon]

@vikas-goel I've identified the problem. The issue is that mountStorage() is not setting c.state.Mounted which unmountStorage() checks before doing anything. After mounting storage you need to do a c.state.Mounted = true and then a c.save().

[vikas-goel]

@vikas-goel I've identified the problem. The issue is that mountStorage() is not setting c.state.Mounted which unmountStorage() checks before doing anything. After mounting storage you need to do a c.state.Mounted = true and then a c.save().

That works. The missing save() was the reason. Thank you @mheon .

[TomSweeneyRedHat]

LGTM
assuming happy tests

[vikas-goel]

/assign @TomSweeneyRedHat

[vikas-goel]

Hi @TomSweeneyRedHat , could you help merge the PR if no other feedback?

[rhatdan]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, vikas-goel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Thanks @vikas-goel

[vikas-goel]

Thank you @rhatdan , @mheon , @TomSweeneyRedHat , @Luap99