-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System test for #9096 (truncated stdout) #9208
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This actually tests conmon, not podman; but that's the whole point of system tests in the first place: if a problem exists, we want to fail loudly, no matter whose fault it is. (I can't get this to fail on my f33 laptop; OP on containers#9096 claims it only fails on Ubuntu. We'll see what happens in CI). Signed-off-by: Ed Santiago <[email protected]>
@giuseppe @haircommander could you take a quick look and LMK if my test logic here is meaningful? Does the podman log output path exercise a close-enough code path to that of plain stdout? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clever to use a log file 👍
I've pulled this in to #8979 where I'm seeing failures from conmon 2.0.25. Hopefully this fails there, and updating to conmon 2.0.26 will fix it, verifying this issue is fixed |
/lgtm |
@haircommander thank you! Although this PR has just merged, could you please follow up with your findings? (Right now I see #8979 stuck in all-red in |
This actually tests conmon, not podman; but that's the whole
point of system tests in the first place: if a problem exists,
we want to fail loudly, no matter whose fault it is.
(I can't get this to fail on my f33 laptop; OP on #9096 claims
it only fails on Ubuntu. We'll see what happens in CI).
Signed-off-by: Ed Santiago [email protected]