-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Herwig6Interface, MCatNLOInterface, PomwigInterface #37612
Drop Herwig6Interface, MCatNLOInterface, PomwigInterface #37612
Conversation
A new Pull Request was created by @iarspider for CMSSW_12_4_DEVEL_X. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-sw/cmsdist#7763 |
please abort |
please test with cms-sw/cmsdist#7763 |
Pull request #37612 was updated. @SiewYan, @smuzaffar, @Dr15Jones, @mkirsano, @makortel, @Saptaparna, @GurpreetSinghChahal, @alberto-sanchez, @santocch can you please check and sign again. |
(last commit should read "... for herwig6") |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PhotosInterface.cc:(.text+0x29fe): undefined reference to `hepevt_' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/PhotosInterface.cc.o: in function `HepMC::HEPEVT_Wrapper::byte_num_to_double(unsigned int)': PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj[_ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj]+0x138): undefined reference to `hepevt_' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj[_ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj]+0x153): undefined reference to `hepevt_' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/PhotosInterface.cc.o:PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper15byte_num_to_intEj[_ZN5HepMC14HEPEVT_Wrapper15byte_num_to_intEj]+0xa3): more undefined references to `hepevt_' follow collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/libPhotosInterfaceDefault.so] Error 1 Leaving library rule at src/GeneratorInterface/PhotosInterface/plugins Entering library rule at src/GeneratorInterface/PhotosInterface/plugins >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-18-2300/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface.cc >> Building edm plugin tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface/libPhotosppInterface.so |
please test |
please test with cms-sw/cmsdist#7806 |
please abort |
please test with cms-sw/cmsdist#7806 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24061/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@cms-sw/generators-l2 , I suggest that we merge this (along with cmsdist PRs) in DEVEL IBs to test full runTheMatrix. If DEVEL IBs show no failure then we can backport these for |
merge |
Original PRs: cms-sw#37610, cms-sw#37611, cms-sw#37612, cms-sw#37616; cmsdist PR: todo
+1 |
PR description:
Drop Herwig6Interface, MCatNLOInterface and PomwigInterface due to removal of legacy MC generators (cms-sw/cmsdist#7763).