Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the MPIService #37605

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 18, 2022

PR description:

Various updates to the MPIService:

  • split MPIService into header, implementation and plugin;
  • add comments about the implementation status of MPI_THREAD_MULTIPLE;
  • add helper function to make sure the MPIService is available;
  • add an option to set the pmix_server_uri OpenMPI parameter.

PR validation:

Integration tests pass:

===== Test "TestHeterogeneousCoreMPIServices" ====
%MSG-i MPIService:  (NoModuleName) 18-Apr-2022 16:11:04 CEST pre-events
The MPI library provides the MPI_THREAD_MULTIPLE multithreading support level
MPI_COMM_WORLD size: 1
MPI_COMM_WORLD rank: 0
MPI processor name:  patatrack03

MPI successfully initialised
%MSG

=============================================

Various updates to the MPIService:
  - split MPIService into header, implementation and plugin;
  - add comments about the implementation status of MPI_THREAD_MULTIPLE;
  - add helper function to make sure the MPIService is available;
  - add an option to set the pmix_server_uri OpenMPI parameter.
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 18, 2022

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 18, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37605/29377

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/MPIServices (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33708a/23985/summary.html
COMMIT: fd71e01
CMSSW: CMSSW_12_4_X_2022-04-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37605/23985/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3589907
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Apr 19, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants