Drop cascade interface #37611

iarspider · 2022-04-19T08:41:52Z

PR description:

Drop CascadeInterface module due to removal of legacy MC generators (cms-sw/cmsdist#7763).

cmsbuild · 2022-04-19T08:42:12Z

A new Pull Request was created by @iarspider for CMSSW_12_4_DEVEL_X.

It involves the following packages:

GeneratorInterface/CascadeInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2022-04-19T08:45:22Z

please test with cms-sw/cmsdist#7763

cmsbuild · 2022-04-19T09:33:29Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/23999/summary.html
COMMIT: 0f7283f
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37611/23999/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/23999/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/23999/git-merge-result

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: Herwig6Hadronizer.cc:(.text+0x5989): undefined reference to `hwcfor_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: Herwig6Hadronizer.cc:(.text+0x598e): undefined reference to `hwcdec_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: Herwig6Hadronizer.cc:(.text+0x5993): undefined reference to `hwdhad_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: Herwig6Hadronizer.cc:(.text+0x5998): undefined reference to `hwdhvy_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: Herwig6Hadronizer.cc:(.text+0x599d): undefined reference to `hwmevt_'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/GeneratorInterface/Herwig6Interface/plugins/GeneratorInterfaceHerwig6Hadronizer/libGeneratorInterfaceHerwig6Hadronizer.so] Error 1
Leaving library rule at src/GeneratorInterface/Herwig6Interface/plugins
Entering library rule at GeneratorInterface/Herwig6Interface
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-18-2300/src/GeneratorInterface/Herwig6Interface/src/Herwig6Instance.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-18-2300/src/GeneratorInterface/Herwig6Interface/src/fastjetfortran_madfks.cc

iarspider · 2022-04-19T11:53:56Z

please test

cmsbuild · 2022-04-19T16:47:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/24010/summary.html
COMMIT: 0f7283f
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37611/24010/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/24010/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/24010/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3589937
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3589913
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 45 edm output root files, 48 DQM output files
TriggerResults: no differences found

SiewYan · 2022-04-20T02:09:22Z

@iarspider , should i sign this (and the other related PR) off in order to retest PR cms-sw/cmsdist#7763 ?

iarspider · 2022-04-20T12:46:08Z

please test with cms-sw/cmsdist#7803

iarspider · 2022-04-20T13:30:49Z

please abort

iarspider · 2022-04-20T13:31:17Z

please test with cms-sw/cmsdist#7803

cmsbuild · 2022-04-20T19:24:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/24060/summary.html
COMMIT: 0f7283f
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37611/24060/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/24060/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc0bc8/24060/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/pool/condor/dir_12891/jenkins/workspace/compare-root-files-short-matrix/data/PR-bc0bc8/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3589937
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3589913
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 45 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2022-04-21T21:30:48Z

@cms-sw/generators-l2 , I suggest that we merge this (along with cmsdist PRs) in DEVEL IBs to test full runTheMatrix. If DEVEL IBs show no failure then we can backport these for master branch.

smuzaffar · 2022-04-21T21:32:55Z

@qliphy @perrotta , we would like to test these changes first in DEVEL IBs, if @cms-sw/generators-l2 has no objections then please include these for next DEVEL IBs ( along with the cmsdist PRs)

Saptaparna · 2022-04-21T22:14:58Z

+1 no objections from my end.

qliphy · 2022-04-21T23:23:36Z

merge
to test for next DEVEL IBs

Original PRs: cms-sw#37610, cms-sw#37611, cms-sw#37612, cms-sw#37616; cmsdist PR: todo

Remove CascadeInterface

0f7283f

cmsbuild added generators-pending orp-pending pending-signatures tests-pending labels Apr 19, 2022

cmsbuild added requires-external tests-started tests-rejected and removed tests-pending tests-started labels Apr 19, 2022

iarspider mentioned this pull request Apr 19, 2022

Drop legacy MC generators cms-sw/cmsdist#7763

Closed

cmsbuild added tests-started and removed requires-external tests-rejected labels Apr 19, 2022

iarspider mentioned this pull request Apr 19, 2022

[Do not merge] Test dropping legacy generator interfaces #37622

Closed

cmsbuild added tests-approved and removed tests-started labels Apr 19, 2022

cmsbuild added requires-external tests-started and removed tests-approved labels Apr 20, 2022

cmsbuild added tests-pending and removed tests-started labels Apr 20, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 20, 2022

qliphy mentioned this pull request Apr 21, 2022

Drop cascade MC generator cms-sw/cmsdist#7803

Merged

cmsbuild added orp-approved and removed orp-pending labels Apr 21, 2022

cmsbuild merged commit 064cf8e into cms-sw:CMSSW_12_4_DEVEL_X Apr 21, 2022

iarspider added a commit to iarspider-cmssw/cmssw that referenced this pull request May 5, 2022

[Forward port] Drop references to legacy generators

a641751

Original PRs: cms-sw#37610, cms-sw#37611, cms-sw#37612, cms-sw#37616; cmsdist PR: todo

iarspider mentioned this pull request May 5, 2022

[master] Drop references to legacy generators #37813

Merged

cmsbuild mentioned this pull request Oct 18, 2023

[DEVEL] drop -Wno-deprecated and -Wno-deprecated-copy flags cms-sw/cmsdist#8766

Merged

cmsbuild mentioned this pull request Nov 17, 2023

[GCC] Build latest GCC 12 with stdcxx backtrace enabled cms-sw/cmsdist#8821

Closed

iarspider deleted the drop-cascade branch February 27, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop cascade interface #37611

Drop cascade interface #37611

iarspider commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

iarspider commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

iarspider commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

SiewYan commented Apr 20, 2022 •

edited by smuzaffar

Loading

iarspider commented Apr 20, 2022

iarspider commented Apr 20, 2022

iarspider commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

smuzaffar commented Apr 21, 2022

smuzaffar commented Apr 21, 2022

Saptaparna commented Apr 21, 2022

qliphy commented Apr 21, 2022

Drop cascade interface #37611

Drop cascade interface #37611

Conversation

iarspider commented Apr 19, 2022

PR description:

cmsbuild commented Apr 19, 2022

iarspider commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

Build

iarspider commented Apr 19, 2022

cmsbuild commented Apr 19, 2022

Comparison Summary

SiewYan commented Apr 20, 2022 • edited by smuzaffar Loading

iarspider commented Apr 20, 2022

iarspider commented Apr 20, 2022

iarspider commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

Comparison Summary

smuzaffar commented Apr 21, 2022

smuzaffar commented Apr 21, 2022

Saptaparna commented Apr 21, 2022

qliphy commented Apr 21, 2022

SiewYan commented Apr 20, 2022 •

edited by smuzaffar

Loading