Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy MC generators #7763

Closed
wants to merge 8 commits into from

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Apr 7, 2022

@cms-sw/generators-l2 We would like to drop the following MC generators:

  • cascade
  • charybdis
  • herwig 6.520
  • jimmy
  • photos 215.5
  • pythia6
  • hydjet 1.9.1
  • tauola 27.121.5
  • toprex

These are ancient and not developed anymore

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

Pull request #7763 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f7900/23714/summary.html
COMMIT: e11082b
CMSSW: CMSSW_12_4_X_2022-04-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7763/23714/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

Pull request #7763 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

Pull request #7763 was updated.

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

(hydjet++ still requires pythia6 and pyquen)

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f7900/23749/summary.html
COMMIT: 3b16178
CMSSW: CMSSW_12_4_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7763/23749/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f7900/23749/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f7900/23749/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593015
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mkirsano
Copy link
Contributor

I had only doubts about cascade, so I asked the responsible person. It is OK to remove it.

@iarspider
Copy link
Contributor Author

@Saptaparna @mkirsano @SiewYan thanks. Is hydjet++ used, or can it also be dropped? It will allow dropping pythia6 and pyquen.

@agrohsje
Copy link

We shouldn't remove hydjet++ (and so P6). This is e.g. needed by HIN group.

@iarspider
Copy link
Contributor Author

@agrohsje noted.

@iarspider
Copy link
Contributor Author

The following PRs for main cmssw repository remove usage of legacy generators:

@stahlleiton
Copy link

Hi @iarspider ,

Was the removal of Hydjet 1.9 discussed in a meeting?
We still heavily use this generator in the HIN PAG (see the minimum bias request for 2018 PbPb in https://cms-pdmv.cern.ch/mcm/requests?prepid=HIN-HINPbPbAutumn18GS-00033&page=0&shown=127) and plan to make the transition to Hydjet++ soon, but we still need the old generator to prepare samples for the Run 3 PbPb data taking.

@iarspider iarspider changed the base branch from IB/CMSSW_12_4_X/master to IB/CMSSW_12_4_X/devel April 20, 2022 08:09
@iarspider
Copy link
Contributor Author

Hi @stahlleiton,

no, it was not discussed. Sure, we can keep hydjet 1.9.

@cmsbuild
Copy link
Contributor

Pull request #7763 was updated.

@iarspider
Copy link
Contributor Author

Splitting into separate PRs as suggested by Shahzad.

@agrohsje
Copy link

dear @stahlleiton. can you comment on what is missing to have hydjet++ for run 3? not pushing to remove 1.9, i am just trying to understand where we are. i assumed that this is ready as priority was very high (and we are discussing already since a bit).

@stahlleiton
Copy link

We are currently producing samples with Hydjet++ and will start a full study comparing Hydjet vs Hydjet++ within the HIN group.

@agrohsje
Copy link

Thanks. Maybe nice to summarize at some point in a GEN meeting? I know it is very special but could still be interesting to see. @cms-sw/generators-l2, what do you think?

@stahlleiton
Copy link

Sure, we can present the results in a GEN meeting once the study is done.

@smuzaffar smuzaffar deleted the drop-ancient-generators branch April 21, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants