Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hydjet (1.9.1) interface #37620

Closed

Conversation

iarspider
Copy link
Contributor

PR description:

Drop HydjetInterface (for hydjet 1.9.1) due to removal of legacy MC generators (cms-sw/cmsdist#7763).

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for CMSSW_12_4_DEVEL_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/AMPTInterface (generators)
  • GeneratorInterface/HijingInterface (generators)
  • GeneratorInterface/HydjetInterface (generators)

@alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@mkirsano, @cbaus, @Martin-Grunewald, @missirol, @alberto-sanchez, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #37620 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please check and sign again.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25a688/24018/summary.html
COMMIT: fdc972c
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37620/24018/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25a688/24018/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25a688/24018/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3589901
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@stahlleiton
Copy link
Contributor

Hi @iarspider ,
The HIN PAG still heavily use Hydjet 1.9 generator (see the minimum bias request for 2018 PbPb in https://cms-pdmv.cern.ch/mcm/requests?prepid=HIN-HINPbPbAutumn18GS-00033&page=0&shown=127) to produce PbPb minbias samples, which are crucial for analysis and run preparation. We plan to start the transition to Hydjet++ soon, but we still need the old generator to prepare samples for the Run 3 PbPb data taking. So please do not remove it yet.
@mandrenguyen

@iarspider
Copy link
Contributor Author

Hi @stahlleiton,

we will keep hydjet 1.9 based on your request.

@iarspider iarspider closed this Apr 20, 2022
@iarspider iarspider deleted the drop-hydjet branch February 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants